818114 - Gaia’s “Legal Information” needs ironing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Fabien Cazenave [:kaze]]

I’ve been urged to land bug 811677 quickly but I think it needs some further ironing.

 • Device Information > Legal Information leads to an almost empty page holding:
    - a "Legal Information" title (which is fine)
    - a "Mozilla" subheading (which I’m not sure makes any point)
    - a truncated and mis-aligned "B2G OS Open Source Notices" item

 • clicking on this item, we get to another page with:
    - a truncated "B2G OS Open Source Notices" title (which is bad)
    - a full-page <iframe> with the license notes, in English

Larissa, would you please review this? I’m not sure we need the intermediate page but I’ll trust your opinion on that.

On the technical side, there are two details that could be fixed:
 • the indentation should be done with *spaces* please, not tabs;
 • the license file name should follow our common guidelines, i.e. no dashes; and it could be stored in resources/open_source_license.html rather than at the root directory.

Comment 1

[Fabien Cazenave [:kaze]]

Attachment: screenshot — "Legal Information"

Comment 2

[Fabien Cazenave [:kaze]]

Attachment: screenshot — "B2G OS Open Source Notices"

Comment 3

[Larissa Co [:lco]]

(In reply to Fabien Cazenave [:kaze] from comment #0)
> I’ve been urged to land bug 811677 quickly but I think it needs some further
> ironing.
> 
>  • Device Information > Legal Information leads to an almost empty page
> holding:
>     - a "Legal Information" title (which is fine)
>     - a "Mozilla" subheading (which I’m not sure makes any point)

I'll explain why we have this in the point below. Actually, we also need a subheading that says "Other" right below the link in the subheading.
 
>     - a truncated and mis-aligned "B2G OS Open Source Notices" item

Why is the text indented so much in this link? There won't be any icon, so feel free to remove the indent. Even removing the indent, I don't know if the text will fit. If it doesn't fit, we might have to shorten it to "Open Source Notices" only. Ping'ing Gerv to see if he's ok with this.

 
>  • clicking on this item, we get to another page with:
>     - a truncated "B2G OS Open Source Notices" title (which is bad)

Let's see if Gerv is ok with just "Open Source Notices". Also, I don't know why your title says "B2G" instead of "Firefox OS" anyway. On my build, it says "Firefox OS". We shouldn't be surfacing "B2G" anywhere in the device because it's not an external name.

>     - a full-page <iframe> with the license notes, in English
> 
> Larissa, would you please review this? I’m not sure we need the intermediate
> page but I’ll trust your opinion on that.

I brought this up as well, but Gerv says that there will be other links on that intermediate page in v1 (potentially from other partners), which is why we have this intermediate page.

> 
> On the technical side, there are two details that could be fixed:
>  • the indentation should be done with *spaces* please, not tabs;
>  • the license file name should follow our common guidelines, i.e. no
> dashes; and it could be stored in resources/open_source_license.html rather
> than at the root directory.

Comment 4

[Fabien Cazenave [:kaze]]

(In reply to Larissa Co from comment #3) 
> Why is the text indented so much in this link? There won't be any icon, so
> feel free to remove the indent. Even removing the indent, I don't know if
> the text will fit. If it doesn't fit, we might have to shorten it to "Open
> Source Notices" only. Ping'ing Gerv to see if he's ok with this.
> 

The indent is caused by the unwanted |class="description"| attribute on the list item, but even without this indent and with the shorter “B2G” string (instead of “Firefox OS”) it doesn’t fit.
So, +1 for using “Open Source Notices” instead if Gerv is OK with that (or just “Open Source”?).

> Let's see if Gerv is ok with just "Open Source Notices". Also, I don't know
> why your title says "B2G" instead of "Firefox OS" anyway. On my build, it
> says "Firefox OS". We shouldn't be surfacing "B2G" anywhere in the device
> because it's not an external name.
> 

The B2G vs. Firefox OS thing is just a matter of branding and depends on the type of build — don’t worry about that.

Comment 5

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 6

[Gervase Markham [:gerv]]

I'm OK with "Open Source Notices" if "Firefox OS Open Source Notices" is too long.

Gerv

Comment 7

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 8

[Evelyn Hung]

Comment on attachment 688715 [details]
patch proposal

r=me, thanks!

Comment 9

[Evelyn Hung]

https://github.com/mozilla-b2g/gaia/pull/6823

Comment 10

[Evelyn Hung]

Oh, I forgot the late-l10n process, we should also add Staś to review this patch so he can notice those late strings.
reopen and add Staś to patch reviewer.

Comment 11

[Fabien Cazenave [:kaze]]

Staś, I’m afraid this patch has been merged already:
https://github.com/mozilla-b2g/gaia/commit/7baaf75636e48af19f91022bddb388167fc5c3d2

Please let us know if that’s OK.

Comment 12

[Evelyn Hung]

Sorry about merging it first. :'(

Comment 13

[Staś Małolepszy :stas]

Comment on attachment 688715 [details]
patch proposal

r=me, post-factum.  Thanks :)