App Permissions List Looks Wrong.

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: patryk, Assigned: gasolin@mozilla.com)

Tracking

unspecified
All
Other

Firefox Tracking Flags

(blocking-b2g:-, b2g18 affected, b2g18-v1.0.1 affected)

Details

(Whiteboard: visual design, incorrect implementation, UX-P2)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 688378 [details]
We can do better...

1a. Can you please vertically center align icons with icons and vertically left align text strings with text strings. Visually you want to have 2 columns. The icon + text string columns look correct. Ones without an icon look incorrect.

1b. Ideally every row would have an icon, please use the generic gray plate + rocket icon if possible.

2. The icons should have a slight drop shadow since they are 50% the size of the app icons, make it 50% of that specification. As you can see some icons are blending with the background

Updated

5 years ago
Component: Gaia::System → Gaia::Settings
Note that the homescreen/system/keyboard... are not going to be displayed in that list anymore.
Patryk and I were speaking about this and he said that the main issue is the lack of a drop shadow with the icons.  To fix this, please just copy the same style from the homescreen but at 50% intensity.
(Assignee)

Updated

5 years ago
Assignee: nobody → gasolin
(Assignee)

Comment 3

5 years ago
Created attachment 721998 [details]
screenshot of drop shadow with the icons
(Assignee)

Comment 4

5 years ago
Created attachment 722002 [details]
polish app permision list by add 50% drop shadow with the icons
Attachment #722002 - Flags: review?(alive)
Attachment #722002 - Flags: review?(alive) → review+
(Assignee)

Comment 5

5 years ago
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/267215315ceb94e0b83bdd41d90f89243bbff6d7

now permission list really looks much better, thanks
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
blocking-b2g: --- → leo?
This needs a rationale for a blocking nom. Based on what I'm what I'm seeing in this bug, this is a VD bug that has no functional impact, which will not block. Feel free to nominate for approval though.
Agreed with Jason, please nominate for uplift as this is a welcome improvement but does not block shipping.
blocking-b2g: leo? → -
(Assignee)

Comment 8

5 years ago
Thanks for clarify, marked for uplift
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected
(Assignee)

Updated

5 years ago
Flags: needinfo?(jhford)
(In reply to Fred Lin [:gasolin] from comment #8)
> Thanks for clarify, marked for uplift

Actually, that's not marking for uplift.  You'll need to get approval-gaia-v1+ to uplift.
Flags: needinfo?(jhford)
You need to log in before you can comment on or make changes to this bug.