Closed Bug 818216 Opened 12 years ago Closed 11 years ago

[Sounds] Unlock Sounds

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
All
Other
Type:
defect

Tracking

(blocking-basecamp:-, b2g18+ affected)

Status:
VERIFIED FIXED
Project Flags:
blocking-basecamp -
Tracking Flags:
Tracking Status
b2g18 + affected

People

(Reporter: padamczyk, Assigned: padamczyk)

Details

(Whiteboard: visual design, incorrect implementation, sound UX-P2 uxbranch, landed in uxbranch, qa-verified) 

Update unlock sounds with the approved design.
Whiteboard: visual design, incorrect implementation, sound UX-P2 → visual design, incorrect implementation, sound UX-P2 uxbranch
Landed in UX Branch https://github.com/gordonbrander/gaia/commit/2f4d3c1ac45b5714b57922a53aa92b06bb948f6a
Whiteboard: visual design, incorrect implementation, sound UX-P2 uxbranch → visual design, incorrect implementation, sound UX-P2 uxbranch, landed in uxbranch
Sound file change only?  Seems to be a little slower opening/unlocking.
Whiteboard: visual design, incorrect implementation, sound UX-P2 uxbranch, landed in uxbranch → visual design, incorrect implementation, sound UX-P2 uxbranch, landed in uxbranch, qa-verfied
Pure sound file swap. The file is about the same size as the old one 9k vs 12k. It shouldn't slow down the process. Perhaps what you're testing against has lock screen performance improvements while the UX branch doesn't.
Ok thanks.

Hrm.  Maybe it's a perception with the click sound.  I tested against without having the sound on... and it seemed slower at the time.  Today's build seems ok.  There might be something odd with having to tap the screen twice in order to wake/unlock.  I can't seem to reproduce it all the time.
helps if I spell verified right.
Whiteboard: visual design, incorrect implementation, sound UX-P2 uxbranch, landed in uxbranch, qa-verfied → visual design, incorrect implementation, sound UX-P2 uxbranch, landed in uxbranch, qa-verified
verified in master, not in v1.


Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"
status-b2g18: --- → affected
Status: RESOLVED → VERIFIED
Vivien, 

Is this ready to raise to approval? with user value and risk in the comments? Our goal is to wrap up all Yedo and VxD changes by April 5th.

Thanks!
Visual design change requesting trackingb2g18
tracking-b2g18: --- → ?
Hi Vivien, this bug is called "[Sounds] Unlock Sounds " but the patch in master is about icons for the connection in settings, svg -> png. Should we change the title?
Flags: needinfo?(21)
I feel like we should change the title as you said to reflect the reality. This patch is already in all versions of gaia so there is no need for any kind of approvals here.
Flags: needinfo?(21)
You need to log in before you can comment on or make changes to this bug.