818230 - Pairing does not stop when cancelled from bluetooth pairing page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Greg Grisco]

1. From bluetooth settings page, attempt to pair with another device

The pairing page is displayed with the other device's name and PIN

2. Press the Cancel button

Returned to the bluetooth settings page.  The moniker under the other device still says "Pairing" and pairing continues until timeout.

Comment 1

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Cancel the pair attempt when the user says "Cancel" and don't show the error dialog when they do

Looks like all our BT reviewers are based in Taipei :).  Hope you guys have a good weekend and we can get this landed soon.

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 689827 [details] [diff] [review]
Cancel the pair attempt when the user says "Cancel" and don't show the error dialog when they do

Review of attachment 689827 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 689827 [details] [diff] [review]
Cancel the pair attempt when the user says "Cancel" and don't show the error dialog when they do

Should have noted that this was a "shotgun" review request ;).

Comment 5

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/b9c807e72f721b980db0e88376c8534b201b9695

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

kaze and I stepped on each other's toes landing this.  Sorry for the dirt in the commit history.

Comment 7

[mlevin]

On Unagi build 20130103070201 the moniker under the other device says "tap to connect" and not "pairing" so this appears to be fixed.