Pairing does not stop when cancelled from bluetooth pairing page

VERIFIED FIXED in B2G C3 (12dec-1jan)

Status

P1
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: ggrisco, Assigned: cjones)

Tracking

unspecified
B2G C3 (12dec-1jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
1. From bluetooth settings page, attempt to pair with another device

The pairing page is displayed with the other device's name and PIN

2. Press the Cancel button

Returned to the bluetooth settings page.  The moniker under the other device still says "Pairing" and pairing continues until timeout.
(Reporter)

Updated

6 years ago
blocking-basecamp: --- → ?
blocking-basecamp: ? → +
Priority: -- → P1

Comment 1

6 years ago
Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.
Target Milestone: --- → B2G C3 (12dec-1jan)
(Reporter)

Updated

6 years ago
Depends on: 802677
Assignee: nobody → jones.chris.g
Created attachment 689827 [details] [diff] [review]
Cancel the pair attempt when the user says "Cancel" and don't show the error dialog when they do

Looks like all our BT reviewers are based in Taipei :).  Hope you guys have a good weekend and we can get this landed soon.
Attachment #689827 - Flags: review?(kaze)
Attachment #689827 - Flags: review?(iliu)
Attachment #689827 - Flags: review?(ehung)
Comment on attachment 689827 [details] [diff] [review]
Cancel the pair attempt when the user says "Cancel" and don't show the error dialog when they do

Review of attachment 689827 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #689827 - Flags: review?(kaze) → review+
Comment on attachment 689827 [details] [diff] [review]
Cancel the pair attempt when the user says "Cancel" and don't show the error dialog when they do

Should have noted that this was a "shotgun" review request ;).
Attachment #689827 - Flags: review?(iliu)
Attachment #689827 - Flags: review?(ehung)
https://github.com/mozilla-b2g/gaia/commit/b9c807e72f721b980db0e88376c8534b201b9695
Status: UNCONFIRMED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
kaze and I stepped on each other's toes landing this.  Sorry for the dirt in the commit history.
Blocks: 802677
No longer depends on: 802677

Comment 7

6 years ago
On Unagi build 20130103070201 the moniker under the other device says "tap to connect" and not "pairing" so this appears to be fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.