818234 - Quickly turning bluetooth off then on results in no device scan

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Greg Grisco]

1. On test device, turn bluetooth off then back on, quickly

expectation:  if there are other BT devices in the field then we should see them displayed in the list

reality:  the device list is empty.  Even paired devices do not show up.

Comment 1

[Dietrich Ayala (:dietrich)]

Confirmed Unagi 12/4 build. I was able to reproduce this, as well as freeze the entire phone while toggling Bluetooth.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Seems like a platform issue. Moving the component.

Comment 3

[Eric Chou [:ericchou] [:echou]]

After the user turn Bluetooth on / off, low-level Bluetooth implementation needs few seconds to actually set up Bluetooth chip, and events will be fired once the process is done. So, if the user turn on / off back and forth very quickly, then the UI and the real state of Bluetooth may be out of sync. 

The solution for this case is to disable the Bluetooth switch button until receiving signals sent from Gecko. After discussion with Evelyn, she will take over this issue.

Eric

Comment 4

[Dietrich Ayala (:dietrich)]

Which means it's back in Gaia, switching.

Comment 5

[Evelyn Hung]

working on it, will provide a patch today.

Comment 6

[Evelyn Hung]

Attachment: see https://github.com/mozilla-b2g/gaia/pull/6875

prevent quickly tapping on bluetooth and wifi settings

Comment 7

[Evelyn Hung]

In my patch above, I didn't spend too much time in CSS tweak, Rudy will help me on the switch style, and submit a follow-up patch here. Thanks.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 689583 [details]
see https://github.com/mozilla-b2g/gaia/pull/6875

Please update the fix and re-request for review again. Thanks.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is a C2 bug, which is due to Monday.

I am told by Evelyn that Rudy is helping on the CSS part. Can we meet C2 deadline on that? If not, we would have to land without that part. I still hope both can land at the same time on the same bug though.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6905

Pointer to Github pull-request

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 690084 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6905

This is a follow-up patch for defining disabled style for switches in building blocks.

Thanks.

Comment 12

[Evelyn Hung]

Comment on attachment 689583 [details]
see https://github.com/mozilla-b2g/gaia/pull/6875

add Rudy's commit in, please take a look again. Thanks!

Comment 13

[Evelyn Hung]

Comment on attachment 690084 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6905

cancel this review request because it has been included above.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thank you both! Let's verify the visual first thing Monday morning :)

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 689583 [details]
see https://github.com/mozilla-b2g/gaia/pull/6875

r=me, thanks Rudy and Evelyn.

Comment 16

[Evelyn Hung]

https://github.com/mozilla-b2g/gaia/pull/6875

Comment 17

[Walter Chen[:ypwalter][:wachen]]

Fixed in https://releases.mozilla.com/b2g/ 20121212 build