TabsTray should have a menu button

VERIFIED FIXED in Firefox 20

Status

()

Firefox for Android
Theme and Visual Design
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sriram, Assigned: sriram)

Tracking

unspecified
Firefox 20
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox20 verified)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
TabsTray should support a menu for the tabs. This needs a TouchDelegate in phones to account for the "Tail" overlapping.
(Assignee)

Updated

6 years ago
Depends on: 818229
(Assignee)

Comment 1

6 years ago
Created attachment 688438 [details] [diff] [review]
Part 1: Tabs Menu

A list of four menu items on tabs-tray:
1. New tab
2. New private tab
3. Synced tabs
4. Close all tabs
Attachment #688438 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

6 years ago
Created attachment 688439 [details] [diff] [review]
Part 2: Give it to someone else

And before someone complains that the menu button is hard to hit. Voila!
Attachment #688439 - Flags: review?(mark.finkle)
Attachment #688438 - Flags: review?(mark.finkle) → review+
Attachment #688439 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

6 years ago
Backout and re-landing due to wrong bug number!
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e3fa909ecd4
https://hg.mozilla.org/integration/mozilla-inbound/rev/5aafc6d684f0

(Sriram learns backing things out.. the hard way :( )
https://hg.mozilla.org/mozilla-central/rev/53a9ec63e32e
https://hg.mozilla.org/mozilla-central/rev/5aafc6d684f0
Assignee: nobody → sriram
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
The menu was added for Tabs Tray on the latest Nightly. Closing bug as verified fixed on:

Firefox 20.0a1 (2012-12-06)
Device: Galaxy S2
OS: Android 4.0.3
Status: RESOLVED → VERIFIED
status-firefox20: --- → verified
Depends on: 835974
You need to log in before you can comment on or make changes to this bug.