Closed Bug 818259 Opened 7 years ago Closed 7 years ago

Remote xpcshell, undefined reference to DMError

Categories

(Testing :: XPCShell Harness, defect)

defect
Not set

Tracking

(firefox18 fixed, firefox19 fixed, firefox20 fixed)

RESOLVED FIXED
Tracking Status
firefox18 --- fixed
firefox19 --- fixed
firefox20 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

Attached patch Patch 1.0 - fixSplinter Review
The "from automationutils import *" line causes syntax checkers like pyflakes problems when checking for undefined references. Pyflakes told me that remotexpcshelltests.py only uses replceBackSlashes from automationutils.py (and runtestsb2g uses nothing).
Attachment #688455 - Flags: review?(jgriffin)
Attachment #688455 - Flags: review?(jgriffin) → review?(mdas)
Comment on attachment 688455 [details] [diff] [review]
Patch 1.0 - fix

Review of attachment 688455 [details] [diff] [review]:
-----------------------------------------------------------------

yay, fewer 'import *'s!
Attachment #688455 - Flags: review?(mdas) → review+
You need to log in before you can comment on or make changes to this bug.