81826 - when embedded with plug/socket toplevel window location caching fails

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Christopher Blizzard (:blizzard)]

When you're embededd using a plug/socket dialog popup windows come up at the
wrong location if the toplevel window has been moved but not resized.  This is
probably because the screen coordinate caching doesn't pick up the configure
notify event because the toplevel window is the inner plug.  Gotta fix that fur
shure d00d!

Comment 1

[Christopher Blizzard (:blizzard)]

Attachment: patch

Comment 2

[Christopher Blizzard (:blizzard)]

The most conspicuous place that this shows up is in Nautilus.  If you have
nautilus and you go to a site that has popup windows and you move the window but
don't resize it and then open up a popup menu the popup will show up at the
wrong place.

This is because in the widget code we cache the last location of the window so
we don't have to make expensive trips to the server to get the location any time
that layout requests it.  Because nautilus uses a plug/socket the toplevel
window is the plug and it doesn't get the configure_event signals when the
toplevel window is moved.

We work around this by using the same mechanism that we use to get the focus
events to get the ConfigureNotify events on the toplevel window and use that to
update our dirty regions.  This seems to work well and is relatively clean.

Comment 3

[Stuart Parmenter]

looks swell. r=pavlov

Comment 4

[tor]

sr=tor

Comment 5

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks!

Comment 6

[Christopher Blizzard (:blizzard)]

oops.  Actually close this.

Comment 7

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!