Approval hook should not reject backout commits that do not contain an a=foo

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

({sheriffing-P1})

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Drives me nuts when backing out.
(Assignee)

Updated

4 years ago
Keywords: sheriffing-P1
Whiteboard: [sheriff-want]
(Assignee)

Comment 1

4 years ago
Created attachment 693391 [details] [diff] [review]
Patch v1

As much as it would make my life easier to also add the exemption to backouts on a closed tree (I frequently hit the hook there too), I think we shouldn't remove the ability to stop pushes, given say infra bustage etc.
Attachment #693391 - Flags: review?(ted)
Comment on attachment 693391 [details] [diff] [review]
Patch v1

Review of attachment 693391 [details] [diff] [review]:
-----------------------------------------------------------------

This seems like a really broad test (starts with "back" or "revert"), but you're the one that deals with sheriffing on a daily basis, not me.
Attachment #693391 - Flags: review?(ted) → review+
(Assignee)

Comment 3

4 years ago
Thank you for the quick review again :-)

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> This seems like a really broad test (starts with "back" or "revert"), but
> you're the one that deals with sheriffing on a daily basis, not me.

Yeah agree, but it's what the tree commit message hook uses (in order to catch {Backout,backed out,back out,...}).

Given that:
* it's rare for a commit message not to start with "bug NNNNNN"
* it's just for the a= check (which frankly is fairly useless anyway)

I doubt we should see any problems from this, so suspect easiest to just land and revisit if there are any issues.
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/hgcustom/hghooks/rev/73339c36fc51
(Assignee)

Updated

4 years ago
Depends on: 823922
(Assignee)

Comment 5

4 years ago
In production.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

Comment 6

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/2b938489e969
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.