818332 - zh-tw builds have {{brandshortName}} in the UI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Tony Chung [:tchung]]

Attachment: screenshot

Tested on the multilocale builds that bhearsum generated.  some screens are still showing the placeholders for {{brandShortName}} 

See screenshot

Repro:
1) install multilocale build, otoro
2) select chinese
3) go to settings, and verify l10n placeholder

Expected:
- localized

Comment 1

[[e-mail] (:bhearsum)]

Given that this is zh-TW only, maybe it's a locale issue?

Comment 2

[Axel Hecht [:Pike]]

The string https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L404 doesn't exist in zh-TW, so it seems that parameter substitution doesn't happen when picking up fallback strings at runtime? Kaze?

Comment 3

[Fabien Cazenave [:kaze]]

Right. This should be fixed by either creating the proper branding.zh-TW.properties file ,or by removing the [zh-TW] (and [fr]…) sections from the branding.ini file here: https://github.com/mozilla-b2g/gaia/blob/master/shared/locales/branding.ini

That being said, l10n.js should be able to ignore non-existing files, see bug 816978.

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

It looks like this string was added on 12-12-12.

https://github.com/mozilla-b2g/gaia/blame/master/shared/locales/branding/unofficial/branding.zh-TW.properties