81835 - Need a way to add DOM event listeners

Status: RESOLVED DUPLICATE of bug 129602

(Core Graveyard :: Embedding: APIs, defect)

Description

[Guy Alfandary]

Currently the only way to do this (AFAIK) is to go through private interfaces.

Comment 1

[Adam Lock]

Moving to 0.9.2

What kind of listeners do you intend to register? C++ or Javascript? Are you 
interested in listening to events bubbling up from subframes? 

Comment 2

[Guy Alfandary]

A mouse listener like the one used in TestGtkEmbed for example.

Comment 3

[James Cooper]

Eh? Do you mean an XPCOM service for adding DOM event listeners?

Sort of like the MailNews MsgMailSession?
http://www.mozilla.org/mailnews/arch/events.html

Or like Embedded has for various browser status things?
http://www.mozilla.org/projects/embedding/listeners.html
That would be sweet.

Comment 4

[Adam Lock]

It may be possible to extend the impl of nsIWebBrowser to support DOM listeners.

Obtaining the nsIEventReceiver interface is very nasty, as GetEventReceiver
demonstrates.

http://lxr.mozilla.org/seamonkey/source/embedding/browser/webBrowser/nsDocShellTreeOwner.cpp#83

However once you obtain the nsIEventReceiver, the methods for subscribing
(addEventListenerByIID & removeEventListenerByIID) are very similar to
nsIWebBrowser's addWebBrowserListener & removeWebBrowserListener. It should be
possible to map calls from one onto the other without breaking the semantics of
the interface.

Comment 5

[Adam Lock]

Downgrading

Comment 6

[Adam Lock]

Attachment: Patch

This patch moves the helper function GetEventReceiver from
nsDocShellTreeOwner.cpp into the nsWebBrowser class and extends
nsIWebBrowser::AddWebBrowserListener & RemoveWebBrowserListener such that they
use it to (de)register DOM event listener objects.

Comment 7

[Adam Lock]

Comment on attachment 113621 [details] [diff] [review]
Patch

Can I have an r/sr on this patch to the webbrowser object. It extends
addWebBrowserListener / removeWebBrowserListener so that embedders may call
these methods to add / remove DOM event listeners.

Most of the patch is just moving a helper method from one source file to
another and making it a member of the nsWebBrowser class.

Thanks

Comment 8

[Conrad Carlen (not reading bugmail)]

Looks nice. No problem with the code itself, but one question: are you sure that
this

+                rv = rcvr->AddEventListenerByIID(domListener, aIID);

maintains only a weak reference to the listener? 

Comment 9

[Marco Pesenti Gritti]

Does someone know the reason this has never been checked in ?

Comment 10

[Marco Pesenti Gritti]

Oh addEventListenerByIID addref the listener :/

Comment 11

[timeless]

[e-mail]: it never got reviews.
http://www.mozilla.org/hacking/life-cycle.html

Comment 12

[Marco Pesenti Gritti]

*** This bug has been marked as a duplicate of 129602 ***