[Email. UX VD] [BB] Apply correct hit state to tool bars.

RESOLVED FIXED

Status

Firefox OS
Gaia::E-Mail
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vicky, Assigned: steveck)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(b2g18 fixed, b2g18-v1.0.1 fixed)

Details

(Whiteboard: visual design, UX P1, [TEF_REQ])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Right now when in hit state of buttons icon disappears and hit state has rounded corners, that's a mistake, Check: http://mozilla-b2g.github.com/Gaia-UI-Building-Blocks/#widgets/toolbars/
(Reporter)

Updated

5 years ago
Assignee: nobody → schung
Whiteboard: visual design, UX P2

Comment 1

5 years ago
screen cap please
Flags: needinfo?(vpg)
(Reporter)

Comment 2

5 years ago
I put the building blocks link just because is not possible to make a screen capture of it, when tapping in an element you cannot make a screen shot.
Flags: needinfo?(vpg)

Updated

5 years ago
Priority: -- → P2
(Reporter)

Comment 3

5 years ago
Created attachment 707064 [details]
shows error, the icon is missing in hit state
(Reporter)

Updated

5 years ago
Whiteboard: visual design, UX P2 → visual design, UX P1, [TEF_REQ]
Blocks: 835757
(Assignee)

Comment 4

5 years ago
Created attachment 708525 [details]
Patch for toolbar layout refinement
Attachment #708525 - Flags: review?(bugmail)
Attachment #708525 - Flags: review?(bugmail) → review+
(Assignee)

Comment 5

5 years ago
Patch merged in master https://github.com/steveck-chung/gaia/commit/46a3369ca0130ede9c074b4c1f8f7930a369830a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Was landed in v1.0.1 as part of Bug 851124 big uplift.
Will land in v1-train tomorrow at the latest too.
status-b2g18-v1.0.1: --- → fixed
Landed in v1-train as part of Bug 851124 big uplift.
status-b2g18: --- → fixed
You need to log in before you can comment on or make changes to this bug.