818465 - [Call log] [BB] Apply list BB

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 692906 [details]
Associated PR.

Adding :borjasalguero as reviewer, as long as this PR contains changes in the JS and he is more familiar with the call log.

Comment 3

[Ismael Gonzalez [:basiclines]]

Comment on attachment 692906 [details]
Associated PR.

Everything looks fine from CSS/Visual part

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Yeah, :borjasalguero is currently checking it not only to provide comments but to unify the behavior of the lists in the SMS and Communications app... ;-) Thanks!
(In reply to Francisco Jordano [:arcturus] from comment #2)
> Comment on attachment 692906 [details]
> Associated PR.
> 
> Adding :borjasalguero as reviewer, as long as this PR contains changes in
> the JS and he is more familiar with the call log.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 692906 [details]
Associated PR.

Despite of adding js, the main goal of this PR is applying building blocks.

As has been mentioned before this kind of changes are mandatory.

a=me

Comment 6

[Axel Hecht [:Pike]]

Can I see a screenshot of contactNameWithOthersSuffix in action? I'm not sure if the manual addition of nbsp is a good idea for all languages.

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Hi :Pike , please see the file I will attach in a second... Anyhow, if you have a device with the latest Gaia you can force it creating a couple of contacts with the same phone number and probably calling it more than 1 time. You can also add a photo to it to see the most complex case... :-) Merry Christmas!!! ;-)

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Call log entry most complex case (several calls, long name, more than 1 contact with the same number and contact photo).

Comment 9

[Axel Hecht [:Pike]]

Thanks for the screenshot. I've also glanced at the code.

I bet we'll see l12y issues down that road at some point, but not necessarily now.