818474 - Consider using -Wc++98-compat with clang

Status: NEW

(Firefox Build System :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

It would warn on cases like

enum foo {
  bar
};

int f() {
  return foo::bar;
}


$ clang test.cpp -c -std=c++11 -Wc++98-compat
test.cpp:6:10: warning: enumeration type in nested name specifier is
      incompatible with C++98 [-Wc++98-compat]
  return foo::bar;


Which in combination with -Werror should avoid bugs like 818381.

Comment 1

[(no longer active)]

What other implications will this have?

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> What other implications will this have?

Not sure, I haven't tried a full build with it, just the reduced test in the description.