818597 - Port the basic functionality test for the downloads panel to per-window PB mode

Status: NEW

(Firefox :: Downloads Panel, defect)

Description

[(no longer active)]

It would be nice to have an automated test for bug 801232.

Comment 1

[(no longer active)]

I tried to take a stab at this.  It's harder than it seems since this test is based on fancy generators, and I don't know how to add a step in the middle of it to open a window in private mode, wait for it to be loaded, and then proceed.  The magic that I was looking for was something like:

function gen_test() {
  const DownloadData = ...

  let win = OpenBrowserWindow({private: true});
  waitForFocus(func /* not sure what func should be! */, win);
  yield;

  // proceed with the rest...
}

but I couldn't get it to work.

Pointers appreciated!

Comment 2

[Josh Matthews [:jdm]]

My suspicion is that there should be some global generator foo that is the result of calling gen_test(), and func should be |function() foo.next()|.

Comment 3

[(no longer active)]

(In reply to comment #2)
> My suspicion is that there should be some global generator foo that is the
> result of calling gen_test(), and func should be |function() foo.next()|.

Isn't that gen_test itself?

Comment 4

[Josh Matthews [:jdm]]

No. The first call to gen_test returns the generator object on which next() should be invoked.

Comment 5

[(no longer active)]

(In reply to comment #4)
> No. The first call to gen_test returns the generator object on which next()
> should be invoked.

OK, I'll let you write the patch since it seems like you know what you're talking about then.  :P

Comment 6

[(no longer active)]

Josh, did you mean to work on this?

Comment 7

[Josh Matthews [:jdm]]

Eep. Yes.

Comment 8

[Marco Bonardo [:mak]]

notice the basic functionality test is disabled per bug 767828, we didn't debug that failure yet