Closed Bug 818627 Opened 12 years ago Closed 12 years ago

INSUFFICIENT_STORAGE error is not triggered correctly

Categories

(Core Graveyard :: DOM: Apps, defect, P1)

ARM
Gonk (Firefox OS)

Tracking

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed, b2g18 fixed)

VERIFIED FIXED
mozilla20
blocking-basecamp +
Tracking Status
firefox18 --- fixed
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: julienw, Assigned: ferjm)

Details

Attachments

(1 file)

STR:
* push a 2395140 kBytes (about 2.3 GB) file in /data
* "adb shell df /data" should report less than 8M free space (eg 6M)
* go to http://owapps.cloudfoundry.com with the browser
* install "big packaged app"
* accept the installation

expected:
* we get a dialog saying that there is not enough storage to install thi sapp

actual:
* nothing happens, expect we have the "downloading" icon on the homescreen, which is confusing but not anormal.


logcat output with Webapps.jsm's debug enabled :

I/Gecko   (  491): -*-*- Webapps.jsm : downloadPackage {"name":"Big Packaged app","csp":"","installOrigin":"http://owapps.cloudfoundry.com","origin":"app://{3867c418-9e66-4bfc-bf4c-2ecdc21e524e}","receipts":[],"installTime":1354735494590,"manifestURL":"http://owapps.cloudfoundry.com/apps/bigPackagedApp/manifest.webapp","appStatus":1,"removable":true,"localId":1026,"progress":0,"installState":"pending","downloadAvailable":true,"downloading":true,"readyToApplyDownload":false,"downloadSize":8657577,"lastUpdateCheck":1354735494591,"etag":null,"basePath":"/data/local/webapps"}
I/Gecko   (  491): -*-*- Webapps.jsm : Free storage: 6316032. Download size: 8657577
I/Gecko   (  491): -*-*- Webapps.jsm : Cleanup: INSUFFICIENT_STORAGE
E/GeckoConsole(  491): [JavaScript Error: "TypeError: download is undefined" {file: "resource://gre/modules/Webapps.jsm" line: 1345}]

I think this is really in Webapps.jsm line 1372 which makes sense because we have no download at this point.

BB? because IMHO this is supposed to work for v1.
Assignee: nobody → ferjmoreno
blocking-basecamp: ? → +
Priority: -- → P1
Attached patch v1Splinter Review
This was a regression introduced by Bug 815547
Attachment #689794 - Flags: review?(fabrice)
Attachment #689794 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/fc3c0bb96080
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Keywords: verifyme
QA Contact: jsmith
Reopening.

There is another error when retrying the download.

STR:
* push a 2395140 kBytes (about 2.3 GB) file in /data
* "adb shell df /data" should report less than 8M free space (eg 6M)
* go to http://owapps.cloudfoundry.com with the browser
* install "big packaged app"
* accept the installation
* we get a dialog saying that there is not enough storage to install this app
* an icon is on the homescreen
* tap on the icon
* accept the download

Expected :
* we get a dialog saying that there is not enough storage to install this app

Actual :
* the download begins, the whole zip is downloaded
* there is a DOWNLOAD_ERROR because the zip can't be installed


logcat says :
I/Gecko   (  109): -*-*- Webapps.jsm : Free storage: 5083136. Download size: undefined

So it seems it doesn't find the download size correctly.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Per ferjm request, I filed Bug 820366 to track this follow-up.

Marking resolved/fixed again.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Whiteboard: [status-b2g18:fixed]
Whiteboard: [status-b2g18:fixed]
Verified today doing some low space testing with appcache preloading for hosted apps and packaged apps.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Summary: UNSUFFICIENT_STORAGE error is not triggered correctly → INSUFFICIENT_STORAGE error is not triggered correctly
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: