818645 - User is unable to scroll entries in the browser's Top Sites, Bookmarks, or History tabs

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Chris Kreinbring [:CKreinbring]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20100101 Firefox/16.0
Build ID: 20121024073032

Steps to reproduce:

Unagi version: 20121205062255
Prerequisite: Have enough sites listed in the Top Sites, Bookmarks, and History tabs to go beyond the device screen's height.

1. From the home screen, launch the browser.
2. Tap the address bar to bring up the list of sites.
3. Attempt to scroll up and down the list in each of the tabs.


Actual results:

The user is unable to scroll any of the lists.


Expected results:

The user is able to scroll up and down the lists.

Comment 1

[Ben Francis [:benfrancis]]

Ooh that's weird, I literally just noticed this five minutes ago. Could this be a regression in Gecko?!

Comment 2

[Ben Francis [:benfrancis]]

Oh I think I've found the bug, it's just a CSS bug.

Comment 3

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/6839

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): caused by bug 816829
User impact if declined: Can't scroll top sites/bookmarks/history!
Testing completed: Inside Firefox & on device
Risk to taking this patch (and alternatives if risky): medium

I've done a bit of refactoring in this patch to simplify michal's earlier patch from bug 809145, un-prefix calc and get rid of a load of CSS properties set in JavaScript.

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 688935 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/6839

merged in: https://github.com/mozilla-b2g/gaia/commit/389835adca88b093612707497f52f24cf437cba6

Comment 6

[Chris Kreinbring [:CKreinbring]]

Verified fixed in Unagi version 20121217070202.