81866 - Installer displays percentages > 100%

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Blake Ross]

Installer just told me I was 102% done in file downloading.

Comment 1

[Sean Su]

It looks like you're using the stub installer now.  Which build did this happen 
with?

My initial guess would be that the dummy talkback.xpi file is being replaced 
with a real talkback.xpi which is larger than the dummy one.  Since this 
replacing process is done after the installer build is done, the new size of the 
real talkback.xpi has not been taken into account.

(wait till you try using http:// protocol to download the files, you could hit 
204% :)  But that is a different bug)

Comment 2

[Blake Ross]

This is 2001051920.  Right, it was getting talkback when I saw the problem.

Comment 3

[Sean Su]

Attachment: patch to fix the extra 2%

Comment 4

[Sean Su]

Blake, could you could r= the trivial patch?  I simply hard coded the size 
values for the real talkback.xpi since it can't be calculated during the 
installer's build process.

The "Install Size Archive=248" (it used to be set to 2) is the one that will 
actually fix the 2%.  The other two values are used to make sure there's enought 
disk space available to install it.

Comment 5

[Daniel (Leaf) Nunes]

i like having talkback be > 100%... it is more than you can get out of the 
mozilla source tree :)

r=leaf for the fix, if you *must* have accurate percentages.

Comment 6

[Blake Ross]

sr=blake

Comment 7

[Henrik Gemal]

This is not fixed with the patch attached. Please take a look at the attached 
screenshots.

Comment 8

[Henrik Gemal]

Attachment: 200% in screenshot

Comment 9

[Henrik Gemal]

Attachment: 161% in screenshot

Comment 10

[Sean Su]

Henrik, please file a different bug.  This bug refers to talkback, not http:// 
protocol.

Comment 11

[Sean Su]

*** Bug 84447 has been marked as a duplicate of this bug. ***

Comment 12

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 13

[Sean Su]

fix checked in.

Comment 14

[K'Trina Medina]

Verified fixed on trunk build 2001070110