818732 - Switch Nightly to per-window private browsing

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

We're very close to a point where we can switch Nightly to per-window private browsing by default.  I'm hoping to do that some time early next week.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Josh Matthews [:jdm]]

Should we do away with the private browsing service here as well?

Comment 3

[(no longer active)]

(In reply to comment #2)
> Should we do away with the private browsing service here as well?

We still need a bit more work for that to happen...  I'll do some of that work tonight.  I'll file a separate bug when I'm ready to remove the PB service, but that doesn't necessarily block us to enable this on Nightly.

Comment 4

[(no longer active)]

(This is the first chunk of work that I was talking about: https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=7dcc0be8d4aa)

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/18baa7203214

Comment 6

[(no longer active)]

Backed out because I had to back out bug 769285: https://hg.mozilla.org/mozilla-central/rev/1fe0626d17c3

Comment 7

[(no longer active)]

Talos seems to be faily happy with this: <http://perf.snarkfest.net/compare-talos/index.html?oldRevs=99f219056c3e&newRev=035274d07e19&tests=a11y,tdhtml,tdhtml_nochrome,a11y_paint,tdhtml_paint,tdhtml_nochrome_paint,tp4,tp4_memset,tp4_pbytes,tp4_rss,tp4_shutdown,tp4_xres,tp4m,tp4m_content_rss,tp4m_main_rss,tp4m_main_rss_nochrome,tp4m_nochrome,tp4m_shutdown,tp4m_shutdown_nochrome,tp5r,tp5r_memset,tp5r_pbytes,tp5r_rss,tp5r_shutdown,tp5r_xres,tp5r_paint,tp5r_memset_paint,tp5r_pbytes_paint,tp5r_%cpu_paint,tp5r_modlistbytes_paint,tp5r_rss_paint,tp5r_shutdown_paint,tp5r_xres_paint,dromaeo_basics,dromaeo_css,dromaeo_dom,dromaeo_jslib,dromaeo_sunspider,dromaeo_v8,tsspider,tsspider_nochrome,tsspider_paint,tsspider_nochrome_paint,v8,tgfx,tgfx_nochrome,tgfx_paint,tgfx_nochrome_paint,tscroll,tsvg,tsvg_opacity,tzoom,ts,ts_paint,ts_cold,ts_cold_generated_max,ts_cold_generated_max_shutdown,ts_cold_generated_med,ts_cold_generated_med_shutdown,ts_cold_generated_min,ts_cold_generated_min_shutdown,ts_cold_shutdown,ts_places_generated_max,ts_places_generated_max_shutdown,ts_places_generated_med,ts_places_generated_med_shutdown,ts_places_generated_min,ts_places_generated_min_shutdown,ts_shutdown,twinopen,tpaint&submit=true>

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/020555b69f72

Comment 9

[Ed Morley [:emorley]]

Backed out for causing bug 821701:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8286fd779a20

Comment 10

[Ed Morley [:emorley]]

(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #9)
> Backed out for causing bug 821701:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/8286fd779a20

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/8286fd779a20

Comment 11

[(no longer active)]

Relanded after disabling the crashing test:

https://hg.mozilla.org/mozilla-central/rev/2798371f1650