81877 - xpconnect threadsafety error reporting can infinitely recur

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[John Bandhauer]

peterv pointed out the problem he was having with the 
DEBUG_ReportWrapperThreadSafetyError recuring in the call to xpc_DumpJSStack

I'll attach a test case that shows the problem, and a patch to fix it.

The test case should be copied to the components directory. It will hit the 
DEBUG_ReportWrapperThreadSafetyError case because Components and 
Components.interfaces are not marked threadsafe in their nsClassInfos (though 
they should be! - that would be another bug)

In the trunk this case will get into infinite recursion. With the patch it will 
report the errors and get on wioth things. 

NOTE that running this test multiple time requites 'touching' the test case .js 
file otherwise the JS component loader will not try to load it on subsequent 
runs.

Comment 1

[John Bandhauer]

Attachment: test case - copy to components dir as foo.js

Comment 2

[John Bandhauer]

Attachment: Oops! ignore previous and try this foo.js in components dir

Comment 3

[John Bandhauer]

Attachment: proposed fix

Comment 4

[Peter Van der Beken [:peterv]]

I have fixed my threadsafety problems in the meantime, but this looks like the
right fix for the infinite recursion. One little nit: WrappepNative should be
WrappedNative in the error message. Other than that, r=peterv.
I haven't had any problems with Components or Components.interfaces.

Comment 5

[John Bandhauer]

> One little nit: WrappepNative should be WrappedNative 

Thanks Peter. I saw this after I posted the diff and fixed it locally. I 
wondered if you'd notice :)

I'll solicit an sr= for this and get it checked in.

Comment 6

[Johnny Stenback (:jst)]

sr=jst, with the fixed typo :-)

Comment 7

[David Bradley]

r=dbradley

Comment 8

[John Bandhauer]

fix checked in

Comment 9

[Phil Schwartau]

Marking Verified -