If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

NR_ASYNC_SCHEDULE() causes leaks if the timers are still active at shutdown

NEW
Unassigned

Status

()

Core
WebRTC: Networking
--
minor
5 years ago
2 years ago

People

(Reporter: jesup, Unassigned)

Tracking

({mlk})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
See bug 816640.  Looking at that, I realized there's no way to cancel these timers, and since they hold a ref to the timer the timer will never be deleted IF we shutdown while the timer is still active.  The callback will get Released() in timer thread shutdown (though hopefully it doesn't need anything significant to be running to die), so we'd likely leak only the Timer.

It's likely to be better to Cancel the timers when the PeerConnection dies.

Note: it only applies if we shutdown with it still running.

If this triggers automation issues due to the possible leak, it may need to be upgraded
(Reporter)

Comment 1

2 years ago
likely moot as we ensure we stop things before shutdown gets that far.
backlog: --- → parking-lot
Whiteboard: [WebRTC] [blocking-webrtc-]
You need to log in before you can comment on or make changes to this bug.