If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Wait time report in Build API uses incorrect explanation text

RESOLVED FIXED

Status

Release Engineering
General
--
trivial
RESOLVED FIXED
5 years ago
5 months ago

People

(Reporter: mcsmurf, Assigned: kartik gupta)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.45 KB, patch
nthomas
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
The wait time report at https://secure.pub.build.mozilla.org/buildapi/reports/waittimes says:
"The number on the Number column is how many minutes a build waited to start, rounded down."
This should probably say:
"The number on the "Wait Time" column is how many minutes a build waited to start, rounded down. The number on the "Number" column is how many builds started within a particular time period."
Its been a long long time since I looked at that page for the wait times (I use the auto-e-mail which is generated from a different template), nor do *I* know how to update the code for that page.

However i found https://mxr.mozilla.org/build/source/buildapi/buildapi/templates/reports/waittimes.mako#102 which I can happily say, "patches accepted" the repo is hg.m.o/build/buildapi
Product: mozilla.org → Release Engineering
(Assignee)

Comment 2

3 years ago
Created attachment 8566483 [details] [diff] [review]
patch1.diff

This is a patch i have written to fix the bug, i didnt know whom to set for the feedback so i am leaving it blank for now.
Flags: needinfo?(bugzilla)
Attachment #8566483 - Flags: feedback?

Updated

3 years ago
Attachment #8566483 - Flags: feedback? → review?(nthomas)

Updated

3 years ago
Flags: needinfo?(bugzilla)
Comment on attachment 8566483 [details] [diff] [review]
patch1.diff

Thanks for writing the patch, which is on the right track and I'll grant f+ (feedback). Lets fix up the English properly while we're here, so please create another patch for me to review.

I'd suggest something like this:
 The <b>Wait Time</b> is the number of minutes a build waited to start, rounded down.
and not worry about Number, that's self-explanatory I think.

Could you also replace 'lister' with 'listed'.
Attachment #8566483 - Flags: review?(nthomas) → feedback+
(Assignee)

Comment 4

3 years ago
Created attachment 8567603 [details] [diff] [review]
patch2.diff

The corrections have been made.
Attachment #8566483 - Attachment is obsolete: true
Attachment #8567603 - Flags: feedback?(nthomas)
Comment on attachment 8567603 [details] [diff] [review]
patch2.diff

Looks good, r+. I've landed it at
  https://hg.mozilla.org/build/buildapi/rev/843f83c7f280
with a version bump added for deployment.
Attachment #8567603 - Flags: review+
Attachment #8567603 - Flags: feedback?(nthomas)
Attachment #8567603 - Flags: checked-in+
Deployed using https://wiki.mozilla.org/ReleaseEngineering/How_To/Update_BuildAPI. Thanks for the patch.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

3 years ago
Nick, can you put my name as the asignee, as i cant see this bug on my profile.
Flags: needinfo?(nthomas)

Updated

3 years ago
Assignee: nobody → kartikgupta0909
Flags: needinfo?(nthomas)
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.