Reimplement MinidumpWriteDump for Windows

NEW
Assigned to

Status

()

Toolkit
Crash Reporting
5 years ago
4 months ago

People

(Reporter: ted, Assigned: PoiLui, Mentored)

Tracking

({student-project})

Trunk
x86
Windows 7
student-project
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=c++], URL)

(Reporter)

Description

5 years ago
Breakpad on Windows relies on calling MiniDumpWriteDump from dbghelp.dll. This is great because we didn't have to write any of that code, but it sucks because MiniDumpWriteDump allocates memory, which means that it fails a lot when we crash due to OOM or heap corruption. The Microsoft documentation warns you about this, but it just tells you that you ought to call it from a separate process. This turns out to be a large and involved project (bug 587729). On Linux and Mac we have our own minidump-writing code which is a lot more careful about allocation (no calls to malloc) and other things that might be unsafe.

Reimplementing this function is a fairly large amount of work, but I think it would provide significant benefits to our crash reporting. It will likely require a fair amount of Win32 internals knowledge. It shouldn't, however, require any knowledge of Mozilla code.

Comment 1

5 years ago
hi sir,
I want to work on this bug,i am well acquainted with the knowledge of c/c++ and would do my best to solve above bug.
(Reporter)

Comment 2

5 years ago
Hi Harsh,

I'll assign this bug to you for now, then. Do you know much about minidumps? If not I can provide you with some resources. Feel free to email me directly, or find me on irc.mozilla.org #introduction as ted.
Assignee: nobody → harshit080

Comment 3

5 years ago
hello,

I too would like to work on this bug. I am good at c/c++. Please guide me through this.

Comment 4

5 years ago
Aish (or Harsh), this is a pretty large project. I would suggest that this is probably not the best project to start on. In any case, you need to understand the structure of a minidump file (starting here) http://msdn.microsoft.com/en-us/library/windows/desktop/ms680378%28v=vs.85%29.aspx
Keywords: student-project

Updated

5 years ago
Assignee: harshit080 → nobody
(Reporter)

Updated

4 years ago
Assignee: nobody → Javaid.Salman

Updated

4 years ago
Assignee: Javaid.Salman → nobody
(Assignee)

Comment 5

4 years ago
Benjamin, I am actually working on the Bug, and have successfully ported the minidump_file_writer_unittest to Windows. Have already informed Ted, and emailed him the updated repository link. Please reassign the Bug to me.

Comment 6

4 years ago
Oh sorry, I didn't see any updates. Feel free to attach WIP patches here.

Also see bug 942873 which I just filed, which is another way to solve this same problem which is probably faster and easier.
Assignee: nobody → Javaid.Salman
Mentor: ted@mielczarek.org
Whiteboard: [mentor=ted][lang=c++] → [lang=c++]
You need to log in before you can comment on or make changes to this bug.