818908 - [traceback] ValueError: Cannot use None as a query value

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Seems like a change was pushed yesterday that's erroring out periodically related to this line:

questions/views.py in aaq

360.            # fully IA-driven (sync isn't special case anymore).
361.            question.add_metadata(product=product['key'])
362.
363.             for p in Product.objects.filter(slug__in=product.get('products')):
364.                 question.products.add(p)

That looks like bad code on line 363. Either this should check to see if 'products' is a key in product and skip the filter if not or it should be doing .get('products', []).

More error details and counts here:

https://errormill.mozilla.org/support/group/190/


This should get fixed ASAP since it's affecting users asking questions and that's bad support.

Comment 1

[Kadir Topal [:atopal]]

Will, can you explain how this is affecting users?

Ricky, does this need an emergency fix?

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pretty sure this prevents a user from asking a question. Someone who knows this code more would know whether that's true or not.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

If I'm reading this correctly, then this affects the sync and other products. In both of those cases, the data doesn't have a 'products' key, so the value is None and then everything goes to hell.

I don't know offhand if we have users asking questions for Sync and Other. If we don't, yet, then we could push this off and don't need an emergency fix.

Having said that, I'm pretty sure that the fix here is pretty easy, so I'm going to grab it and do it now.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a pull request: https://github.com/mozilla/kitsune/pull/998

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/f11c6b0c1d032990bf3d4b5c528aecda1dc18efe

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed to production just now.

Comment 7

[Kadir Topal [:atopal]]

Thanks, Will! We do have people asking Sync questions IIRC, so this was helpful indeed.