Closed Bug 818972 Opened 12 years ago Closed 11 years ago

Make all custom django form validation return constants in solitude

Categories

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kumar, Assigned: davidbgk)

References

Details

(Whiteboard: u=patron c=pmt p=1)

When raising custom validation errors in solitude, we need the consumer to translate the error messages. For this reason, let's use constant strings as error messages such as 'BRIEF_DESCRIPTION_OF_ERROR'. This will hint to developers that they *cannot* change the error strings unless they update all API consumers.

Example of strings to fix: https://github.com/mozilla/solitude/blob/master/lib/buyers/forms.py

The consumer fix for is in webpay: https://github.com/mozilla/webpay/blob/master/lib/solitude/errors.py
Priority: -- → P2
Assignee: nobody → kumar.mcmillan
Priority: P2 → P3
Whiteboard: u=patron c=pmt p=1
Version: 1.0 → 1.2
Target Milestone: --- → 2013-03-14
Target Milestone: 2013-03-14 → 2013-03-21
Target Milestone: 2013-03-21 → ---
Version: 1.2 → 1.3
Target Milestone: --- → 2013-08-27
Target Milestone: 2013-08-27 → 2013-09-03
Target Milestone: 2013-09-03 → 2013-09-10
Target Milestone: 2013-09-10 → 2013-09-17
Target Milestone: 2013-09-17 → ---
Assignee: kumar.mcmillan → david
You need to log in before you can comment on or make changes to this bug.