819050 - Marionette response containing element has raw ID instead of JSON object

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jim Evans]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121128204232

Steps to reproduce:

After properly establishing a session, navigate to a page containing an element with the id attribute set to '2'. Execute the following command via Marionette, substituting the appropriate values for your session.

{"to":"conn0.marionette1","type":"findElement","session":"8","using":"id","value":"2"}


Actual results:

I received the following response:

{
  "from": "conn0.marionette1",
  "value": "{db9ca612-a761-4085-85d0-62a7b6144b05}"
}


Expected results:

I should receive the following response:

{
  "from": "conn0.marionette1",
  "value": 
  {
    "ELEMENT": "{db9ca612-a761-4085-85d0-62a7b6144b05}"
  }
}

Every other WebDriver-compliant server component returns element references in this way. It ensures that when the executeScript command is called, the client can tell the difference between an element reference returned by the JavaScript function, and a string that just happens to look like an internal WebDriver element ID.

Comment 1

[Jonathan Griffin (:jgriffin)]

This will be slightly tricky to fix, since it will require synchronized changes to both client and server.   But, we need it for webdriver compatibility.

Comment 2

[David Burns :automatedtester]

Attachment: Marionette response containing JSON object with element details instead of raw ID;

Comment 3

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/772c99944a84

Comment 4

[David Burns :automatedtester]

Attachment: bug819050.patch

Attaching rebased patched and carrying r+ forward

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/772c99944a84

Comment 6

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/51b7db60a117