819071 - [DIALER] Verify that the calls registers show the phone Carrier

Status: VERIFIED INVALID

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[mlevin]

Attachment: Carrier Not Shown

Unagi build 20121206071128

See screen shot.

Steps:
1-Open call log with some registers

Expected:
The call registers show the phone Carrier.

Actual:
Phone carriers donot show up in list of calls in the Call Log.

Comment 1

[Tony Chung [:tchung]]

is this a feature that we want supported in v1?

Comment 2

[ayman maat :maat]

referencing:
wireframe pack : HTML5_Dialer_Contacts_20120810_R2S1_V6.0
page : 11
annotation : 04
"
04 Mode of communication icon, Contact Name, phone number type and Carrier
     - Carrier is taken from the notes field of the associated phone number. refer to wireframe : ‘add contact’
         1) In case the call is linked to a contact the information to be shown by default for a call log entry is:
             The phone number type and the carrier (phone notes) 
             Exceptions:
                   - If a contact has two phone numbers with the same type and carrier (phone notes), in that case it should be displayed the following information:
                         * Phone number type and Phone Number literal.
                   - If the phone number does not have a carrier (phone notes). In this case, it should be displayed the following information:
                        * Phone number type and Phone Number literal.
"

...therefore if there is no content in the notes field for respective contacts, this is not a bug. Could you please confirm content of notes field.

Comment 3

[mlevin]

2 Questions:
1. There is no "notes" field on the Unagi. There is a field titled "Carrier" under the field "Phone" and there is a field titled "Comment" at the bottom of the Contact screen. Are one of these what you are referring to? 

2. Are you saying that if notes of the carrier type are manually entered when setting up the contact using one of the aforementioned fields as described in my first question, that those notes should show up in the Call Logs?

Comment 4

[ayman maat :maat]

(In reply to mlevin from comment #3)
> 2 Questions:
> 1. There is no "notes" field on the Unagi. There is a field titled "Carrier"
> under the field "Phone" and there is a field titled "Comment" at the bottom
> of the Contact screen. Are one of these what you are referring to? 

Yes, sorry, 'notes' field is now called 'carrier'. This is the field i am referring to.


> 2. Are you saying that if notes of the carrier type are manually entered
> when setting up the contact using one of the aforementioned fields as
> described in my first question, that those notes should show up in the Call
> Logs?

Yes! What i am saying is whatever information is manually entered into the 'carrier' field should show up in the call log in the position you are referring to in this bug you have raised.

...as a side note for your reference. the presence of a carrier field is a business requirement and has been discussed at length though out the course of this project. It would obviously be highly desirable to automatically pick up a contacts carrier, but apparently this is either not universally possible or feasible for V1. This is why we have a manual input field.

Comment 5

[mlevin]

This test case passes now that I have received your information of how this is suppose to work. Please resolve/close this bug and I am going to invalidate the test case in Moztrap (Dialer #2238) since it is incorrectly worded.