819084 - release kickoff should be able to store output from release runner

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect, P3)

Description

[[e-mail] (:bhearsum)]

Release runner has a lot of output for each release that it processes. Kickoff should be able to store and show all of that for both debugging purposes and posterity.

Comment 1

[[e-mail] (:bhearsum)]

I've spent a bunch of time trying to find a way to get all output to both the console and sent to release kickoff. Because of all the subprocesses we use, and our inability to pass 'stdout' and 'stderr' to them, I haven't been able to find a way. My latest attempt ended up with almost what we want, except with some duplicate lines for anything that goes through a LogHandler:
https://github.com/bhearsum/tools/blob/e4f65af57e4a9bf47bbcbb82a6e6a086841c7f87/buildfarm/release/release-runner.py
https://github.com/bhearsum/tools/blob/e4f65af57e4a9bf47bbcbb82a6e6a086841c7f87/lib/python/kickoff/log.py
https://github.com/bhearsum/tools/blob/e4f65af57e4a9bf47bbcbb82a6e6a086841c7f87/lib/python/util/log.py

I don't think it's worthwhile to spend forever making this work. As an alternative, we can make sure failure fail from release runner gets sent to all interested parties.

Might revisit this down the road, but probably not anytime soon.

Comment 2

[[e-mail] (:bhearsum)]

Oh, and my release kickoff branch with server side support is here: https://github.com/bhearsum/release-kickoff/tree/even-more-status

Comment 3

[[e-mail] (:bhearsum)]

Mass component change for ship it bugs.

Comment 4

[[e-mail] (:bhearsum)]

ship it has stored basic output for failures for a long time, and this hasn't come up since. If we need something else, we'll fine a new bug.