[DIALER] Verify that if the contact has no name, it should include the literal "Unknown" instead of the contact name, besides the Phone number literal.

VERIFIED WORKSFORME

Status

Firefox OS
Gaia::Dialer
VERIFIED WORKSFORME
6 years ago
6 years ago

People

(Reporter: mlevin, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: interaction [UX-P2], testrun 2, [TEF_REQ])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 689411 [details]
Unknown does not appear next to contact with just a phone number

Unagi build 20121206071128

See attached screenshot.

Steps:
1-Receive a call from a contact with number but no contact name 
2-Make a call to a contact with number but no contact name 
3-Receive a missed call from a contact with number but no contact name 
4-Open call log.

Expected:
As the contact has no name, it should include the literal "Unknown" instead of the contact name, besides the Phone number literal. This behaviour should be the same for incoming, outgoing and missed calls.

Actual:
"Unknown" does not appear in the call log.

Comment 1

6 years ago
referencing:
wireframe pack : HTML5_Dialer_Contacts_20120810_R2S1_V6.0
page : 11
annotation : 04

"2) If the contact has no name, [the module in the contact call log] should include the literal "Unknown" instead of the contact name."
Whiteboard: interaction [UX-P2]

Comment 2

6 years ago
UCID: dialer-000
https://moztrap.mozilla.org/results/case/62151/
Whiteboard: interaction [UX-P2] → interaction [UX-P2], testrun 2
It appears that the current implementation has changed, and I am wondering if this bug is still valid. Today, instead of displaying an empty line, we move the phone number up a line so it is more prominent. It appears to be an elegant solution to me, ayman - thoughts?
Flags: needinfo?(aymanmaat)

Updated

6 years ago
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → ARM

Comment 4

6 years ago
(In reply to Kevin Grandon from comment #3)
> It appears that the current implementation has changed, and I am wondering
> if this bug is still valid. Today, instead of displaying an empty line, we
> move the phone number up a line so it is more prominent. It appears to be an
> elegant solution to me, ayman - thoughts?

In isolation this is a suitable solution. However: 

1) there are other fields that have now come to the forefront that need to be taken into consideration / that take precedence over phone number if they have content such as 'company'. Therefore the solution of only promoting the phone number is not necessarily correct.

2) we need consistency with with information delivered in other related apps as well. In the instance of the call log the instance of the contacts app is one that the information needs to be consistent with.

I am currently working on a matrix of what should be shown where and when. I will attach it when i am done.

This bug is also related to: Bug 829510
Flags: needinfo?(aymanmaat)

Comment 5

6 years ago
This bug is also influenced by: Bug 804402

Updated

6 years ago
Whiteboard: interaction [UX-P2], testrun 2 → interaction [UX-P2], testrun 2, [TEF_REQ]
Solved as a consequence of applying a preliminary version of Ayman's matrix in https://bugzilla.mozilla.org/show_bug.cgi?id=829510 ;-)

Please, see the information which should be shown as detailed in that but (https://bugzilla.mozilla.org/show_bug.cgi?id=829510).
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME

Comment 7

6 years ago
Verified this has been resolved and fixed per bug 829510. Unagi device on Build 20130211070202 Dec 5th Kernel.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.