819173 - Don't let packaged apps have a META-INF/ on upload

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Validation, defect)

Description

[Rob Hudson [:robhudson]]

META-INF/ is reserved for our use. We should block packaged apps that have anything in this folder already.

Comment 1

[Matt Basta [:basta]]

Done:

https://github.com/mozilla/app-validator/commit/05d78453937b2322033cc190b86d49e8db23aa63

Comment 2

[krupa raj[:krupa]]

Attachment: app with META-INF

I just uploaded this app and saw no validation errors @ https://marketplace-dev.allizom.org/developers/upload/d31e31b47dec4be3acc6f2161e130d93

Reopening for investigation. If the app turned out to be fault, please close the bug and I'll verify.

Comment 3

[Matt Basta [:basta]]

-dev wasn't updated but now it is.

Comment 4

[Lisa Brewster [:adora]]

A submission was able to get past this check, we should probably figure out why...

https://marketplace.firefox.com/developers/app/terra/file/187234/validation

Comment 5

[Christopher Van Wiemeersch [:cvan]]

http://f.cl.ly/items/2G2e0l3G2o1F2I3v3B20/Screen%20Shot%202013-01-24%20at%204.10.01%20PM.png

Comment 6

[Matt Basta [:basta]]

Can you attach the zip in question Lisa?

Comment 7

[Lisa Brewster [:adora]]

Dunno how to get the raw zip.  I can do this, though:  https://marketplace.firefox.com/files/browse/187234/

Also have another example:  https://marketplace.firefox.com/files/browse/188966/

Comment 8

[Matt Basta [:basta]]

Both of the two URLs appear to be empty.

I can't repro the problem with the attached ZIP, so unless I can get a zip which contains a META-INF directory and can get past the validator, I can't do much.

Please reopen if you find one (don't delete/reject that app until I can snag a copy).