819179 - improve environment filtering

Status: RESOLVED FIXED

(Testing Graveyard :: Mozpool, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Right now, requests filter devices by environment the hard way - get all available devices, then look for one with the right environment.  This is pretty silly.

The data.get_free_devices function should be expanded to take environment as an argument.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug819179.patch

no functionality change, just a refactor

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 693933 [details] [diff] [review]
bug819179.patch

Review of attachment 693933 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: runtests.py
@@ +214,5 @@
> +                         environment='bar', device_name='device2')),
> +                         sorted([ ]))
> +        self.assertEqual(sorted(data.get_free_devices(
> +                         environment='bar', device_name='device3')),
> +                         sorted([ 'device3' ]))

Nit: if we're trying to standardize coding styles in mozpool, there shouldn't be any spaces around [] in Python (according to PEP-8).  I realize this is already in a lot of places, but new code should be mostly PEP-8, I'm thinking.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Yeah, bad habit. I blame Buildbot (which is really blaming me..).

Fixed and landed.