819189 - Importing a read only calendar and trying to view the event - should not be able to edit the event

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[Jason Smith [:jsmith]]

Build:

Device - Unagi

Hashes

  <project name="releases/gaia" path="gaia" remote="mozillaorg" revision="3ad4e525a43a44b3c6eb905304fc0648ca5fd9b8"/>
  <project name="releases/gecko" path="gecko" remote="mozillaorg" revision="74bff8c0506e6ff91666095b432fbc6aed9621fe"/>

Steps:

1. Import a calendar that is read only
2. Try to edit the event for the calendar

Expected:

You shouldn't be able to edit the event.

Actual:

Editing capabilities and saving the edits is possible. Obviously the server won't update with the changes, since this is read only (silently fails).

Noming here mainly cause this could be relatively common scenario and the silent failure is likely to spurt some confusion (user expectation is it was saved, but in reality, it wasn't).

Comment 1

[James Lal [:lightsofapollo]]

This should be easy we already have the permission information (from caldav) and we also have readonly hooks that we use for recurring events.

Comment 2

[James Lal [:lightsofapollo]]

Assigning to C3 hopefully that is correct.

Comment 3

[James Lal [:lightsofapollo]]

Its not strictly related but the format google returns its "Contact's Birthdays" calendar events is very malformed. I made various workarounds at the ICAL layer so we could support that calendar and those changes will land here as well.

Comment 4

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6903

Pointer to Github pull-request

Comment 5

[James Lal [:lightsofapollo]]

Comment on attachment 690057 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6903

Harder to review this bit without knowing a little about caldav.
I made an attempt to document this fairly well so it was clear what each permission actually does.

Comment 6

[James Lal [:lightsofapollo]]

Quick note- I don't automatically upgrade anyone to have these permissions the effects of this patch will be visible after the user syncs (it will remove all options to modify read only calendars).

It should also now be impossible to sync write only calendars.
Additionally we hide the "Save" text for readonly events.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 690057 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6903

I have lack of knowledge on CalDav/iCal interfaces, but this makes sense logically and looks pretty good from a style/syntax PoV. R+ from me.

Comment 8

[James Lal [:lightsofapollo]]

Hi Jason,

This patch _should_ resolve the last of the google issues related to syncing events (and correctly handing permissions in calendars in general). I have some special workarounds included in this patch for the issues I found but its possible there are other oddities I am unaware of.

Can you give your google calendar another shot?

Comment 9

[Les Orchard [:lorchard]]

Comment on attachment 690057 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6903

Doesn't look like I'm needed for a review here

Comment 10

[Jason Smith [:jsmith]]

Hmm...confirmed to be working with my zimbra calendar that's read only. Not sure if it works with google accounts though...digging into this now.

Comment 11

[Jason Smith [:jsmith]]

Looks good.