819228 - Gaia's build/utils.js writeContent should preserve unicode encoding

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

using writeContent to write unicode into a file results in broken file

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

Comment 2

[Alexandre Poirot [:ochameau]]

I don't see any issues with our manifest files being in UTF8.

I see errors when I encode any manifest in something else than UTF8, as platform code try to read them in this charset. But it still fails with your patch.

So which concrete issues are your addressing here with this patch?

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

When reading and writing back HTML files that contain UTF8 chars I'm loosing all charcodes if I don't use the patch.

Comment 4

[Fabien Cazenave [:kaze]]

I’m using a `writeContent_UTF8' variant in the patch I proposed for bug 821691.

If the latter lands, I guess we can close this bug. We could also make bug 821691 depend on this one.

Comment 5

[Fabien Cazenave [:kaze]]

fixed along with bug 821691:
https://github.com/mozilla-b2g/gaia/commit/5fe546fda8a44a33e8feea782530b1827dd4ca1c