[Settings] Double click on button in Settings will cause the page cannot back to previous one

VERIFIED FIXED in B2G C3 (12dec-1jan)

Status

P2
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: atsai, Assigned: arthurcc)

Tracking

unspecified
B2G C3 (12dec-1jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Click twice on a button in settings panel will cause the page cannot go back to previous one. This happens in several pages.

Reproduce Steps:
1. Tap on "Settings" app
2. Tap on "Device Information"
3. Click "More Information" twice
4. Tap on "<" to go back to previous one

Expected Result:
*. Back to "Device Information" page

Actual Result:
*. Cannot go back to "Device Information" page
(Reporter)

Updated

6 years ago
QA Contact: atsai
(Reporter)

Updated

6 years ago
blocking-basecamp: --- → ?
(Reporter)

Comment 1

6 years ago
I'll say it's a major usability blocker.
Let's use bug 818056 to collect all the issues of inconsistent panel flow. Lots of recent bugs seem to have the same root cause.
Blocks: 818056
blocking-basecamp: ? → +
Priority: -- → P2
I've been looking at this, and it appears that there is a weird issue where gecko is not properly repainting after a transition. I think I have a workaround for the meantime, but will continue looking for the root cause. I'll take this one.
Assignee: nobody → kgrandon
Created attachment 690178 [details]
Patch Obsolete. See #818056
Attachment #690178 - Flags: review?
Comment on attachment 690178 [details]
Patch Obsolete. See #818056

(I don't know if there's anyone watching out for "in the wind" review requests, so I'm directing this at Eveyln)
Attachment #690178 - Flags: review? → review?(ehung)
Target Milestone: --- → B2G C3 (12dec-1jan)

Comment 6

6 years ago
Comment on attachment 690178 [details]
Patch Obsolete. See #818056

This PR is the same as the one in bug 818056, I'll close the request here. To avoid redundant review work, could you just comment here "the patch had been proposed in bug xxx" and obsolete this patch? Thanks.
Attachment #690178 - Flags: review?(ehung)
Comment on attachment 690178 [details]
Patch Obsolete. See #818056

Didn't mean to cause confusion, sorry about that. Obsoleting this patch.
Attachment #690178 - Attachment description: Github pull request pointer → Patch Obsolete. See #818056
Attachment #690178 - Attachment is obsolete: true

Comment 8

6 years ago
I tested and investigated this problem more, now I think it's not depends or a dup of 818056, because it happens on Gecko 18. 
Remove blocks tag first.
No longer blocks: 818056

Comment 9

6 years ago
Arthur is helping on investigating it, add to cc list.
When double click on the link, the original hash and the current hash become the same. After that, when back button is pressed, it tries to go back using the original hash and which is the current hash itself.
Created attachment 691229 [details] [diff] [review]
Patch

A WIP patch for your reference.

It ignores the request of openDialog if the dialogID is the same as the current hash.
Arthur - That seems to work for me. Do you want to submit a pull request and mark me as a reviewer?
Assignee: kgrandon → arthur.chen
Created attachment 691679 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6991

Ignore same hash request.
Attachment #691679 - Flags: review?(ehung)

Comment 14

6 years ago
Comment on attachment 691679 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6991

r=me, please squash your commits into one and start with the bug number in your commit message. Thank you!
Attachment #691679 - Flags: review?(ehung) → review+
Fixed. 
https://github.com/mozilla-b2g/gaia/commit/e3fdd94beec893ec7010db2d2bcd86961da6c6d2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 16

6 years ago
Verified in 2012-12-20 Nightly build
Status: RESOLVED → VERIFIED
(Reporter)

Updated

6 years ago
Duplicate of this bug: 823847
You need to log in before you can comment on or make changes to this bug.