819247 - [Settings] Double click on button in Settings will cause the page cannot back to previous one

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Al Tsai [:atsai]]

Click twice on a button in settings panel will cause the page cannot go back to previous one. This happens in several pages.

Reproduce Steps:
1. Tap on "Settings" app
2. Tap on "Device Information"
3. Click "More Information" twice
4. Tap on "<" to go back to previous one

Expected Result:
*. Back to "Device Information" page

Actual Result:
*. Cannot go back to "Device Information" page

Comment 1

[Al Tsai [:atsai]]

I'll say it's a major usability blocker.

Comment 2

[Gene Lian (I already quit Mozilla)]

Let's use bug 818056 to collect all the issues of inconsistent panel flow. Lots of recent bugs seem to have the same root cause.

Comment 3

[Kevin Grandon :kgrandon]

I've been looking at this, and it appears that there is a weird issue where gecko is not properly repainting after a transition. I think I have a workaround for the meantime, but will continue looking for the root cause. I'll take this one.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Patch Obsolete. See #818056

Comment 5

[:Margaret Leibovic]

Comment on attachment 690178 [details]
Patch Obsolete. See #818056

(I don't know if there's anyone watching out for "in the wind" review requests, so I'm directing this at Eveyln)

Comment 6

[Evelyn Hung]

Comment on attachment 690178 [details]
Patch Obsolete. See #818056

This PR is the same as the one in bug 818056, I'll close the request here. To avoid redundant review work, could you just comment here "the patch had been proposed in bug xxx" and obsolete this patch? Thanks.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 690178 [details]
Patch Obsolete. See #818056

Didn't mean to cause confusion, sorry about that. Obsoleting this patch.

Comment 8

[Evelyn Hung]

I tested and investigated this problem more, now I think it's not depends or a dup of 818056, because it happens on Gecko 18. 
Remove blocks tag first.

Comment 9

[Evelyn Hung]

Arthur is helping on investigating it, add to cc list.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

When double click on the link, the original hash and the current hash become the same. After that, when back button is pressed, it tries to go back using the original hash and which is the current hash itself.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Patch

A WIP patch for your reference.

It ignores the request of openDialog if the dialogID is the same as the current hash.

Comment 12

[Kevin Grandon :kgrandon]

Arthur - That seems to work for me. Do you want to submit a pull request and mark me as a reviewer?

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/6991

Ignore same hash request.

Comment 14

[Evelyn Hung]

Comment on attachment 691679 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6991

r=me, please squash your commits into one and start with the bug number in your commit message. Thank you!

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Fixed. 
https://github.com/mozilla-b2g/gaia/commit/e3fdd94beec893ec7010db2d2bcd86961da6c6d2

Comment 16

[Al Tsai [:atsai]]

Verified in 2012-12-20 Nightly build