819277 - [Browser] missing thumbnails when a place has no screenshot

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P3)

Description

[Tim Taubert [:ttaubert] (inactive)]

When a place doesn't have a .screenshot property I get this:

E/GeckoConsole( 7560): [JavaScript Error: "NS_ERROR_INVALID_POINTER: Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIDOMMozURLProperty.createObjectURL]" {file: "app://browser.gaiamobile.org/js/browser.js" line: 1341}]

We should be able to display top sites without a thumbnail/screenshot. The fix is easy.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6881/files

Pointer to Github pull-request

Comment 2

[Dietrich Ayala (:dietrich)]

What happens? Default thumbnail shown? White space? Unless the whole page can't be displayed, not going to block on this. Please re-nom if it breaks the whole page.

Comment 3

[Dietrich Ayala (:dietrich)]

Please go through approval process to land this.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Dietrich Ayala (:dietrich) from comment #2)
> What happens? Default thumbnail shown? White space? Unless the whole page
> can't be displayed, not going to block on this. Please re-nom if it breaks
> the whole page.

The whole top-site div is not shown because the .forEach() call aborts with an error. Subsequent top-sites should not be shown as well. Not sure what counts as "breaking the whole page" but it just stays white and empty so I think this doesn't block.

Comment 5

[Dietrich Ayala (:dietrich)]

I guess a clearer criteria would be: Does just that top-site not show, or do no top-sites show?

Sounds like the latter, so blocking+.

Comment 6

[Dietrich Ayala (:dietrich)]

Hm, another clarifying question: How often will a top-site not have a thumbnail, and why?

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Dietrich Ayala (:dietrich) from comment #6)
> Hm, another clarifying question: How often will a top-site not have a
> thumbnail, and why?

Good question. The site that was failing for me was some kind of WAP portal. Not sure how I got into that situation and if I can reproduce it. The fix seemed so easy to me that I didn't really try to dig into it much further (although I understand this would help categorizing this better).

Comment 8

[Dietrich Ayala (:dietrich)]

I'd be happy with a fix that handled thumbnail-less top-sites by putting a placeholder image.

Comment 9

[Ben Francis [:benfrancis]]

Thanks for the patch, sorry for the slow review.

https://github.com/mozilla-b2g/gaia/commit/4053179d9461671c20b2ed98f5bd2659cb74e9a9

Comment 10

[Sreenidhi]

Bug in browser, thumbnail-less top-sites on restarting browser, did not render the site. Patch updated.
Tested on a Unagi Device. 

Reviewd and VERIFIED on:

Build ID : 20130102070202 
Device : Unagi