everything.me icon is blurry in privacy tab

RESOLVED WORKSFORME

Status

Firefox OS
Gaia::Everything.me
P4
minor
RESOLVED WORKSFORME
5 years ago
5 years ago

People

(Reporter: julienw, Assigned: Peter La)

Tracking

({polish})

unspecified
ARM
Gonk (Firefox OS)
polish

Firefox Tracking Flags

(blocking-basecamp:-)

Details

(Whiteboard: visual design UX-P4)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
STR:
* Go to Settings > Device Information > Your Privacy

Expected:
* all icons are nice and sharp.

Actual :
Firefox and Marketplace's icon are sharp, everything.me icon is blurry.


see https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/images/privacy_sprite.png
Flags: needinfo?(padamczyk)
Flags: needinfo?(gbrander)
Whiteboard: visual design
Not a visual design is exactly... Everything.me needs to provide settings a 30x30px icon for that screen. I suspect a 16x16px icon is being up scaled.
Component: Gaia::Settings → Gaia::Everything.me
Flags: needinfo?(padamczyk)
blocking-basecamp: ? → -
Keywords: polish
Priority: -- → P4
Whiteboard: visual design → visual design UX-P4
This blurry icon is part of a static sprite (see link). It's not scaled by CSS. We need an icon from E.me at the proper resolution.
Flags: needinfo?(gbrander)
(Reporter)

Comment 3

5 years ago
I'd say it was once scaled ;)
I've worked with the Twist team and supplied the appropriate icons

https://github.com/basiclines/gaia/blob/twist-nightly/apps/settings/style/images/privacy_sprite.png
https://github.com/basiclines/gaia/blob/twist-nightly/apps/settings/style/images/privacy_sprite%402x.png

How do you want to proceed?
(Reporter)

Updated

5 years ago
Flags: needinfo?(padamczyk)
The icons look fine. Now we need someone to integrate them.
Flags: needinfo?(padamczyk)
(Reporter)

Comment 6

5 years ago
Patryk, could someone from the UX team do this ?
Patryk, do you want me to create a PR for this? I'm guessing the only change would be of the image..
Assignee: nobody → padamczyk
Peter I believe you fixed this part of the brand update. Can you attach the merge #
Assignee: padamczyk → pla
(Assignee)

Comment 9

5 years ago
This bug should be fixed by the fixes for these two bugs:
Bug 828251 - https://github.com/gordonbrander/gaia/pull/92
Bug 830903 - Sam Jochimek has submitted a fix for this, but from what I can tell, it is wrong... so I'll have to talk to him about it.
(Reporter)

Comment 10

5 years ago
Bug 828251 actually pushed https://github.com/mozilla-b2g/gaia/blob/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb/shared/resources/branding/official/privacy_sprite.png and https://github.com/mozilla-b2g/gaia/blob/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb/shared/resources/branding/unofficial/privacy_sprite.png

Bug I don't see this is different on my build though ?
Keywords: qawanted
Created attachment 705880 [details]
screenshot from 1/24/2013 nightly

I believe the 828251 had already landed in the main branch?
in this pull : https://github.com/mozilla-b2g/gaia/pull/7716

I think the main issue is the bug 830903.  That hasn't landed in the main branch yet, it's something I have to test this week/today.

It's the main reason why you don't see the difference.
removing qawanted; taking it as QA, and marking it as a dependency on bug 830903.  I'll try to verify this along with the other today.
Depends on: 830903
Keywords: qawanted
QA Contact: nhirata.bugzilla
yup.  bug 830903 should fix this issue... along with the change in bug 828251; so in essence I believe it's a dup.  please double check
(Reporter)

Comment 14

5 years ago
looks good both in FTU and in Settings.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.