STR: * Go to Settings > Device Information > Your Privacy Expected: * all icons are nice and sharp. Actual : Firefox and Marketplace's icon are sharp, everything.me icon is blurry. see https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/images/privacy_sprite.png
Not a visual design is exactly... Everything.me needs to provide settings a 30x30px icon for that screen. I suspect a 16x16px icon is being up scaled.
This blurry icon is part of a static sprite (see link). It's not scaled by CSS. We need an icon from E.me at the proper resolution.
I'd say it was once scaled ;)
I've worked with the Twist team and supplied the appropriate icons https://github.com/basiclines/gaia/blob/twist-nightly/apps/settings/style/images/privacy_sprite.png https://github.com/basiclines/gaia/blob/twist-nightly/apps/settings/style/images/privacy_sprite%402x.png How do you want to proceed?
The icons look fine. Now we need someone to integrate them.
Patryk, could someone from the UX team do this ?
Patryk, do you want me to create a PR for this? I'm guessing the only change would be of the image..
Peter I believe you fixed this part of the brand update. Can you attach the merge #
This bug should be fixed by the fixes for these two bugs: Bug 828251 - https://github.com/gordonbrander/gaia/pull/92 Bug 830903 - Sam Jochimek has submitted a fix for this, but from what I can tell, it is wrong... so I'll have to talk to him about it.
Bug 828251 actually pushed https://github.com/mozilla-b2g/gaia/blob/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb/shared/resources/branding/official/privacy_sprite.png and https://github.com/mozilla-b2g/gaia/blob/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb/shared/resources/branding/unofficial/privacy_sprite.png Bug I don't see this is different on my build though ?
Created attachment 705880 [details] screenshot from 1/24/2013 nightly I believe the 828251 had already landed in the main branch? in this pull : https://github.com/mozilla-b2g/gaia/pull/7716 I think the main issue is the bug 830903. That hasn't landed in the main branch yet, it's something I have to test this week/today. It's the main reason why you don't see the difference.
removing qawanted; taking it as QA, and marking it as a dependency on bug 830903. I'll try to verify this along with the other today.
yup. bug 830903 should fix this issue... along with the change in bug 828251; so in essence I believe it's a dup. please double check
looks good both in FTU and in Settings.