Closed Bug 819371 Opened 9 years ago Closed 9 years ago

Weird list of arguments passed to query.cgi when accessing advanced search

Categories

(Bugzilla :: Query/Bug List, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

(Keywords: regression)

Attachments

(1 file)

4.4 and older not affected, trunk only: click the "Search" link in the page header or footer. See the long list of arguments passed to query.cgi for no reasons.
I take that back: 4.4 is also affected, but 4.2 is not. This is a regression due to bug 730670.
Depends on: 730670
Flags: blocking4.4+
Target Milestone: Bugzilla 5.0 → Bugzilla 4.4
Version: 4.5 → 4.4
Attached patch patch, v1Splinter Review
This fixes the problem with Firefox. I tested with Opera too, but it works as expected with and without my patch. I also tested with IE6, but clicking the Back button fails with and without my patch; only the first item of boolean charts comes back.

I have no idea why this fixes the problem with Firefox nor if that's the correct fix or not, for both HTML5-capable and non-capable browsers. So don't trust it without testing it a bit.
Attachment #703041 - Flags: review?(glob)
Summary: Weird list of arguments passed to query.cgi when accessing this page → Weird list of arguments passed to query.cgi when accessing advanced search
Comment on attachment 703041 [details] [diff] [review]
patch, v1

r=glob

what's going on here is the long URL you're seeing is the one that's built when you alter custom search parameters, so going back in your browser works. it uses history.js to provide a window.History object, which is used regardless of the browser's capabilities.

by shifting initialisation of this object to after the custom search form is initialiased, you've effectively skipped setting the history during the initial load.

tested with fx release, fx nightly and ie8.
Attachment #703041 - Flags: review?(glob) → review+
Flags: approval?
Flags: approval4.4?
Assignee: query-and-buglist → LpSolit
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/search/boolean-charts.html.tmpl
Committed revision 8563.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified template/en/default/search/boolean-charts.html.tmpl
Committed revision 8511.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.