819415 - Revise subject of [release] emails for esrtest updates to mention esrtest channel

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement, P3)

Description

[u279076]

Currently, the automated [release] emails indicate betatest as the test channel:
> [release] Firefox 17.0.1esr build1: Updates available on betatest

This can be a bit confusing, especially for those not familiar with our processes, because the test channel for ESR builds is actually esrtest. I suggest we update the email to indicate the correct channel.
> [release] Firefox 17.0.1esr build1: Updates available on esrtest

Comment 1

[[e-mail] (:bhearsum)]

This shouldn't be too hard to do. Suggested implementation:
* Templatize the "betatest" words in the update mail template: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/release_templates/updates_success
* Add a "updateVerifyChannel" to the desktop release configs
* Make sure updateVerifyChannel is available in locals here, otherwise it won't get passed to the template interpreter: https://github.com/mozilla/build-buildbotcustom/blob/master/process/release.py#L147
* Pass updateVerifyChannel to the ReleaseUpdatesFactory, remove hardcoding of "betatest" in it.
* Adjust the tests: https://github.com/mozilla/build-buildbotcustom/blob/2f333c2193cb463ac5f418c60fe2703d88ee4b44/test/test_process_factory.py

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

The last esr sent:
  [release] Firefox 31.2.0esr build3: Updates available on esrtest

Got fixed as part of bug 986990.