819544 - [email/IMAP] gmail IMAP disabled regexp does not detect IMAP being disabled at a domain level.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P4)

Description

[Deepa Subramanian]

Attachment: screenshot - bad error msg

Unagi Build ID:2012 1207062543  V 1.0.0

Steps to Reproduce: 
1. Go to email app
2. Set up an email account using "other email" option 
3. Enter Name, email and password (eg [e-mail]) 
4. Sync the email acct 
 
Actual result: 

After few days tried to open emails from the acct set up. "Bad password" error msg appears with "Retry with new password button". When retry button is clicked it. It populates emails that has already been synced before. Press the "drawer icon" to go to account settings. Found last sync "!" .

Expected result: 
1. Should be able to sync email from "other email". 
2. Should give a proper error message as there was no sync.
3. Pressing "Retry with new password" button should have not taken back to inbox.

Comment 1

[Deepa Subramanian]

Attachment: Last sync screen shots

Comment 2

[Deepa Subramanian]

Attachment: Logcat

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Thank you very much for the logcat!

The adb logcat indicates:

Connect error: bad-user-or-pass formal: Error: Error while executing request: [ALERT] IMAP access is disabled for your domain. Please contact your domain administrator for questions about this feature. (Failure) on imap.googlemail.com 993

This suggests we should add a regexp detection for this case in adddition to our check for individuals which is:
'[ALERT] Your account is not enabled for IMAP use.'

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

er, and if it's not clear, we interpret this as a password failure because it's a reasonable guess.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

BB+, P3 - user should be informed of what happened.

Comment 6

[Jim Porter (:squib)]

(In reply to Andrew Sutherland (:asuth) from comment #4)
> er, and if it's not clear, we interpret this as a password failure because
> it's a reasonable guess.

Looking at the UI, why don't we have an option for manually configuring the account if we get a bad username/password response? I really think that should be a second button, just in case we end up sending the wrong username.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Jim Porter (:squib) from comment #6)
> (In reply to Andrew Sutherland (:asuth) from comment #4)
> > er, and if it's not clear, we interpret this as a password failure because
> > it's a reasonable guess.
> 
> Looking at the UI, why don't we have an option for manually configuring the
> account if we get a bad username/password response? I really think that
> should be a second button, just in case we end up sending the wrong username.

Can you describe the situation you are envisioning that would lead to this?  We should only create accounts after successful credential validation, and e-mail servers should not be changing the username portion out from under us.  This bug is certainly not an example where manual configuration would make sense.

Comment 8

[Jim Porter (:squib)]

(In reply to Andrew Sutherland (:asuth) from comment #7)
> Can you describe the situation you are envisioning that would lead to this? 
> We should only create accounts after successful credential validation, and
> e-mail servers should not be changing the username portion out from under
> us.  This bug is certainly not an example where manual configuration would
> make sense.

Oh, is this a screen we get *after* setup? I thought the setup screen had changed. Nevermind!

Comment 9

[Chris Lee [:clee]]

This sounds like an edge case for the target audience.  Minus'ing, thanks.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Fixing this as part of bug 816039.

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

This is now fixed.  This was done in https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/99 as part of bug 809552.

Note that we give the same error as if it was a single-user account with IMAP disabled.  Presumably the gmail UI will tell them they need their administrator to turn IMAP on or something like that.

Comment 12

[Nick Davidson]

Resolved - verified on Unagi build 20130102070202

Comment 13

[Natalya Kot [:nkot]]

no repro in build 20130112070202 for Unagi -shown message "You must enable IMAP for your Gmail account"