MozHttpd class should inherit from SimpleServer

NEW
Assigned to

Status

defect
7 years ago
6 years ago

People

(Reporter: k0scist, Assigned: mihneadb)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

https://github.com/mozilla/mozbase/blob/master/mozhttpd/mozhttpd/mozhttpd.py#L164

Unless there is a good reason we are avoiding inheriting from python's
SimpleServer, which we utilize anyway.
I see that we use EasyServer which inherits from BaseHTTPServer. Do you want to remove EasyServer, make MozHttpd inherit from SimpleHTTPServer and just use that?
Yes, that sounds right.
Assignee: nobody → mihneadb
Attachment #711242 - Flags: review?(jhammel)
Comment on attachment 711242 [details] [diff] [review]
refactor as requested

This looks good to me.  I am not sure if this breaks existing stuff though so am giving the review over.  :jmaher, if you don't know or don't have time to look into this, could you pass the buck to :wlach?  And if he doesn't know he can pass the buck back to me for an r+ unless :ted wants to untangle this madness.
Attachment #711242 - Flags: review?(jhammel) → review?(jmaher)
For what it's worth, the mozbase tests pass.
(In reply to Mihnea Dobrescu-Balaur (:mihneadb) from comment #5)
> For what it's worth, the mozbase tests pass.

Sadly, that ain't worth much :(
Comment on attachment 711242 [details] [diff] [review]
refactor as requested

Review of attachment 711242 [details] [diff] [review]:
-----------------------------------------------------------------

I remember originally wanting to go with BaseHttpServer, but the path of least resistance was SimpleHttpServer.  Please ensure that the performance of this is the same, I recall an attempt early on when loading about 1000 pages in a row took an order of magnitude longer.
Attachment #711242 - Flags: review?(jmaher) → review+
Blocks: 819664
You need to log in before you can comment on or make changes to this bug.