819550 - MozHttpd class should inherit from SimpleServer

Status: RESOLVED INACTIVE

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

https://github.com/mozilla/mozbase/blob/master/mozhttpd/mozhttpd/mozhttpd.py#L164

Unless there is a good reason we are avoiding inheriting from python's
SimpleServer, which we utilize anyway.

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

I see that we use EasyServer which inherits from BaseHTTPServer. Do you want to remove EasyServer, make MozHttpd inherit from SimpleHTTPServer and just use that?

Comment 2

[(not currently active) Ted Mielczarek]

Yes, that sounds right.

Comment 3

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: refactor as requested

Comment 4

[Jeff Hammel]

Comment on attachment 711242 [details] [diff] [review]
refactor as requested

This looks good to me.  I am not sure if this breaks existing stuff though so am giving the review over.  :jmaher, if you don't know or don't have time to look into this, could you pass the buck to :wlach?  And if he doesn't know he can pass the buck back to me for an r+ unless :ted wants to untangle this madness.

Comment 5

[Mihnea Dobrescu-Balaur (:mihneadb)]

For what it's worth, the mozbase tests pass.

Comment 6

[Jeff Hammel]

(In reply to Mihnea Dobrescu-Balaur (:mihneadb) from comment #5)
> For what it's worth, the mozbase tests pass.

Sadly, that ain't worth much :(

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 711242 [details] [diff] [review]
refactor as requested

Review of attachment 711242 [details] [diff] [review]:
-----------------------------------------------------------------

I remember originally wanting to go with BaseHttpServer, but the path of least resistance was SimpleHttpServer.  Please ensure that the performance of this is the same, I recall an attempt early on when loading about 1000 pages in a row took an order of magnitude longer.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:gbrown, could you have a look please?
For more information, please visit auto_nag documentation.