Closed Bug 819578 Opened 13 years ago Closed 12 years ago

Panel should not inject style on each show

Categories

(Add-on SDK Graveyard :: General, defect, P2)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: irakli, Assigned: jsantell)

Details

Attachments

(2 files)

GH Pull Request 845
355 bytes, text/html
irakli
: review-
Details
GH Pull Request 845
379 bytes, text/plain
jsantell
: review+
Details
At the moment panel seems to inject platform specific styling each time it's open, that's terrible for the memory.
Assignee: nobody → rFobic
Assignee: rFobic → jsantell
Attached file GH Pull Request 845 —
Attachment #722533 - Flags: review?(rFobic)
Attachment #722533 - Attachment filename: file_819578.txt → file_819578.html
Attachment #722533 - Attachment mime type: text/plain → text/html
Attachment #722533 - Flags: review?(rFobic) → review-
Attached file GH Pull Request 845 —
Resubmitting after talking to Irakli, will roll into initialization method after Trait/Symbiont refactoring in Irakli's branch
Attachment #726900 - Flags: review?(rFobic)
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/ad2aba3fb8b580549c2704854c7ed98f879ead9a Fix bug 819578, Default styles in panels should only be applied once a=@gozala https://github.com/mozilla/addon-sdk/commit/d3050d167d57c838642a678621e7139098316467 Merge pull request #873 from jsantell/apply-panel-style-once-819578 Fix bug 819578, Default styles in panels should only be applied once, a=@gozala
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 726900 [details] GH Pull Request 845 This was cleared along time ago, updating status
Attachment #726900 - Flags: review?(rFobic) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: