Closed Bug 819784 Opened 12 years ago Closed 12 years ago

PLMN entries reading is broken for SPDI

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(blocking-basecamp:+)

Status:
RESOLVED DUPLICATE of bug 819790
Project Flags:
blocking-basecamp +

People

(Reporter: gerard-majax, Assigned: gerard-majax)

Details

Attachments

(1 file)

Trivial fix
874 bytes, patch
Details | Diff | Splinter Review 
After bug 793111 got merged, I'm noticing an issue: the readPLMNEntries() call in getSPDI's callback is invalid, it should be "this.readPLMNEntries(tlvLen/6);" instead of "readPLMNEntries(tlvLen/6);".
Summary: PLMN entries reading is doubly broken → PLMN entries reading is broken for SPDI
Attached patch Trivial fix — — Splinter Review 
Attaching the trivial fix
blocking-basecamp: --- → ?
Assignee: nobody → lissyx+mozillians
Alexandre, can you tell us what this means from a user perspective?
You can't switch to Orange in white areas in France, for example.
blocking-basecamp: ? → +
Also see bug 793111
Attachment #690205 - Flags: review?
Attachment #690205 - Flags: review? → review?(vyang)
Comment on attachment 690205 [details] [diff] [review]
Trivial fix

Review of attachment 690205 [details] [diff] [review]:
-----------------------------------------------------------------

Please move this trivial patch to bug 819790. They are all follow-up fixes of bug 793111 and bug 819790 provides test cases.
Attachment #690205 - Flags: review?(vyang)
No longer blocks: 819790
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: