819801 - Verify SQLite's memory reporting is accurate

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Nicholas Nethercote [inactive]]

We use SQLite's built-in memory reporting, and assume that it is correct.  Since we provide the allocator that SQLite uses, it should be easy to check if this is actually true.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: In DMD builds, check that SQLite's reporting of its total memory consumption are correct.

It's a small patch.  SQLite's numbers match ours, which is nice!

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: In DMD builds, check that SQLite's reporting of its total memory consumption are correct.

A marginally tweaked version.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8333628 [details] [diff] [review]
In DMD builds, check that SQLite's reporting of its total memory consumption are correct.

A storage peer should review this, but I strongly suspect there are thread safety issues here.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: In DMD builds, check that SQLite's reporting of its total memory consumption are correct.

This version makes gSqliteMemoryUsed an Atomic<size_t>, which should fix the
thread-safety issues.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8333670 [details] [diff] [review]
In DMD builds, check that SQLite's reporting of its total memory consumption are correct.

Yeah, threading would have been a concern.  mozilla::Atomic seems to have that exceedingly well in hand.

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c75acfe2076

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c75acfe2076