Closed
Bug 819834
Opened 10 years ago
Closed 10 years ago
B2G STK: the options should be null if the typeOfCommand is STK_CMD_POLL_OFF or STK_CMD_REFRESH.
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(2 files, 2 obsolete files)
3.91 KB,
patch
|
Details | Diff | Splinter Review | |
2.19 KB,
patch
|
Details | Diff | Splinter Review |
The options should be null if the typeOfCommand is STK_CMD_POLL_OFF or STK_CMD_REFRESH. (See MozStkCommand in dom/icc/interface/SimToolKit.idl)
Assignee | ||
Comment 1•10 years ago
|
||
1). The field, 'options', exported to DOM should be null when processing 'STK_CMD_POLL_OFF' or 'STK_CMD_REFRESH'. 2). ril_worker will handle 'STK_CMD_MORE_TIME', no need to propagate event to DOM. 3). The tag ,'COMPREHENSIONTLV_FILE_LIST', seems wrong, correct it.
Assignee | ||
Comment 2•10 years ago
|
||
Marionette tests for 'STK_CMD_POLL_OFF' and 'STK_CMD_REFRESH'
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → echen
Assignee | ||
Updated•10 years ago
|
Attachment #690703 -
Flags: review?(allstars.chh)
Assignee | ||
Updated•10 years ago
|
Attachment #690705 -
Flags: review?(allstars.chh)
Comment 3•10 years ago
|
||
Comment on attachment 690703 [details] [diff] [review] Part 1: The options should be null, v1 Review of attachment 690703 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +5030,5 @@ > + return; > + } > + > + cmdDetails.options = StkCommandParamsFactory.createParam(cmdDetails, ctlvs); > + cmdDetails.rilMessageType = "stkcommand"; swap these two lines, so we know we are about to send 'stkcommand' and its data. @@ +7925,5 @@ > switch (refreshType) { > case STK_REFRESH_FILE_CHANGE: > case STK_REFRESH_NAA_INIT_AND_FILE_CHANGE: > let ctlv = StkProactiveCmdHelper.searchForTag( > + COMPREHENSIONTLV_TAG_FILE_LIST, ctlvs); Good catch!
Attachment #690703 -
Flags: review?(allstars.chh) → review+
Updated•10 years ago
|
Attachment #690705 -
Flags: review?(allstars.chh) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Address review comment #3
Attachment #690703 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
try server: https://tbpl.mozilla.org/?tree=Try&rev=4f90381c0867
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
I got conflict when trying to push part 2. Please rebase again.
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/eddc239db462 https://hg.mozilla.org/integration/mozilla-inbound/rev/caf2b8ec76f9
Keywords: checkin-needed
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eddc239db462 https://hg.mozilla.org/mozilla-central/rev/caf2b8ec76f9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•