Closed Bug 819834 Opened 8 years ago Closed 8 years ago

B2G STK: the options should be null if the typeOfCommand is STK_CMD_POLL_OFF or STK_CMD_REFRESH.

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(2 files, 2 obsolete files)

The options should be null if the typeOfCommand is STK_CMD_POLL_OFF or STK_CMD_REFRESH.
(See MozStkCommand in dom/icc/interface/SimToolKit.idl)
Blocks: b2g-stk
1). The field, 'options', exported to DOM should be null when processing 'STK_CMD_POLL_OFF' or 'STK_CMD_REFRESH'.
2). ril_worker will handle 'STK_CMD_MORE_TIME', no need to propagate event to DOM.
3). The tag ,'COMPREHENSIONTLV_FILE_LIST', seems wrong, correct it.
Attached patch Part 2: Marionette tests, v1 (obsolete) — Splinter Review
Marionette tests for 'STK_CMD_POLL_OFF' and 'STK_CMD_REFRESH'
Assignee: nobody → echen
Attachment #690703 - Flags: review?(allstars.chh)
Attachment #690705 - Flags: review?(allstars.chh)
Comment on attachment 690703 [details] [diff] [review]
Part 1: The options should be null, v1

Review of attachment 690703 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +5030,5 @@
> +      return;
> +    }
> +
> +    cmdDetails.options = StkCommandParamsFactory.createParam(cmdDetails, ctlvs);
> +    cmdDetails.rilMessageType = "stkcommand";

swap these two lines,
so we know we are about to send 'stkcommand' and its data.

@@ +7925,5 @@
>      switch (refreshType) {
>        case STK_REFRESH_FILE_CHANGE:
>        case STK_REFRESH_NAA_INIT_AND_FILE_CHANGE:
>          let ctlv = StkProactiveCmdHelper.searchForTag(
> +          COMPREHENSIONTLV_TAG_FILE_LIST, ctlvs);

Good catch!
Attachment #690703 - Flags: review?(allstars.chh) → review+
Attachment #690705 - Flags: review?(allstars.chh) → review+
Address review comment #3
Attachment #690703 - Attachment is obsolete: true
Keywords: checkin-needed
I got conflict when trying to push part 2.
Please rebase again.
Keywords: checkin-needed
rebase only
Attachment #690705 - Attachment is obsolete: true
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.