Closed
Bug 819836
Opened 12 years ago
Closed 11 years ago
Lock Screen doesn't Set Window behind It to Hidden.
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P2)
Tracking
(blocking-basecamp:+)
People
(Reporter: mchen, Assigned: alive)
References
Details
Attachments
(1 file, 1 obsolete file)
We expect a window behind the Lock Screen can be as hidden state but actually it is not.
Assignee | ||
Comment 1•12 years ago
|
||
The story is under this condition, our honored audio competing policy doesn't work because the app under lockscreen is still visibile. We do this already: 1.setVisible to the app in window manager by some complex codes when app transitioning 2.setVisible to the app in attention screen module when attention screen shows/hides. And the lost pieces of setVisible: 1. Lockscreen behind app 2. Popup Manager(window.open) behind app 3. Inline activity behind app
Assignee: nobody → alive
blocking-basecamp: --- → ?
Comment 3•12 years ago
|
||
(In reply to Marco Chen [:mchen] from comment #0) > We expect a window behind the Lock Screen can be as hidden state but > actually it is not. Changing back to ? until we find out what audio logic this impacting. What's the user impact?
blocking-basecamp: + → ?
Comment 4•12 years ago
|
||
We need this to fix bug 796333, which is blocking-basecamp+.
Updated•12 years ago
|
blocking-basecamp: ? → +
Comment 5•12 years ago
|
||
:alive, how close are you on this one? this is blocking some other work...
Assignee | ||
Comment 6•12 years ago
|
||
Patch coming today. (In reply to Faramarz (:faramarz) from comment #5) > :alive, how close are you on this one? this is blocking some other work...
Assignee | ||
Comment 7•11 years ago
|
||
Patch proposal: 1. Centralize the setVisibility function to window manager 2. Dispatch some events in attention screen 3. Listen to lock/unlock event in window manager Tested manually all the day and encounter bug 820698
Attachment #691243 -
Flags: review?(timdream+bugs)
Comment 8•11 years ago
|
||
Comment on attachment 691243 [details] https://github.com/mozilla-b2g/gaia/pull/6964 Discussed offline. Please modify and re-request for review again. We would also need to discuss with Etienne on the attention screen part.
Attachment #691243 -
Flags: review?(timdream+bugs)
Comment 9•11 years ago
|
||
add C3 milestone to BB+ bug so it doesn't get missed in C3 query
Target Milestone: --- → B2G C3 (12dec-1jan)
Comment 10•11 years ago
|
||
This is blocking C2 bug 967333, what's the left here?
Comment 11•11 years ago
|
||
And that bug number should've been 796333.
Assignee | ||
Comment 12•11 years ago
|
||
patch v2 I don't cancel the app animation when same origin attention screen is there in this patch in the long run. Time costing and bug and undefined behavior expected.
Attachment #691243 -
Attachment is obsolete: true
Attachment #692168 -
Flags: review?(timdream+bugs)
Comment 13•11 years ago
|
||
Comment on attachment 692168 [details]
PR 7014
r=me, with the event listener fix. You can check with me later if you would like me to review it again after the change.
Attachment #692168 -
Flags: review?(timdream+bugs) → review+
Assignee | ||
Comment 14•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/51f60cb2d70489dc252bfad189a4b7e3122c3041
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•