819907 - add permanent fullsc-toggler element to simplify code

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[ithinc]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20121204 Firefox/20.0
Build ID: 20121204030754

Steps to reproduce:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-fullScreen.js#49
49         let fullScrToggler = document.getElementById("fullscr-toggler");
50         if (!fullScrToggler) {
51           fullScrToggler = document.createElement("hbox");
52           fullScrToggler.id = "fullscr-toggler";
53           fullScrToggler.collapsed = true;
54           gNavToolbox.parentNode.insertBefore(fullScrToggler, gNavToolbox.nextSibling);
55         }
56         fullScrToggler.addEventListener("mouseover", this._expandCallback, false);
57         fullScrToggler.addEventListener("dragenter", this._expandCallback, false);
58       }

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-fullScreen.js#157
157     let fullScrToggler = document.getElementById("fullscr-toggler");
158     if (fullScrToggler) {
159       fullScrToggler.removeEventListener("mouseover", this._expandCallback, false);
160       fullScrToggler.removeEventListener("dragenter", this._expandCallback, false);
161     }

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-fullScreen.js#173
173       let fullScrToggler = document.getElementById("fullscr-toggler");
174       if (fullScrToggler) {
175         fullScrToggler.removeEventListener("mouseover", this._expandCallback, false);
176         fullScrToggler.removeEventListener("dragenter", this._expandCallback, false);
177       }

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-fullScreen.js#509
509     let toggler = document.getElementById("fullscr-toggler");
510     if (toggler) {
511       toggler.collapsed = aShow;
512     }



Expected results:

The "fullscr-toggler" would be better constructed in browser.xul and cached in FullScreen object.

Comment 1

[ithinc]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 692668 [details] [diff] [review]
patch

Looks good to me!

Comment 3

[ithinc]

Attachment: patch v2

Comment 4

[ithinc]

Comment on attachment 692672 [details] [diff] [review]
patch v2

Replace _isChromeCollapsed with !_fullScrToggler.collapsed.

Comment 5

[ithinc]

Attachment: patch for checkin (as v1)

Comment 6

[ithinc]

"Replace _isChromeCollapsed with !_fullScrToggler.collapsed" will be handled in a followup.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d83930c9a712

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d83930c9a712