819965 - Unable to silence or control FM radio volume via 'audio.volume.content' (or using the device rocker)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Aaron Train [:aaronmt]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0978db919b27 via bug 814326 comment #6 indicates that `audio.volume.content` can be used for volume control of the FM radio. 

Toggling `audio.volume.content` from default volume to `0` has no effect. With my headphones in I can still hear tuned frequencies (albeit static in most cases).

--
Tested via Unagi-eng 12/09

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

I think it's possible that the index 0 just lowest the volume but FM chip still active, user may hear very small sound in a quite environment.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This isn't quiet for me, adjusting the volume makes no difference. I can replicate this manually with unagi. The hardware volume buttons do not adjust the volume delivered through the headphones.

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

(In reply to Dave Hunt (:davehunt) from comment #2)
> This isn't quiet for me, adjusting the volume makes no difference. I can
> replicate this manually with unagi. The hardware volume buttons do not
> adjust the volume delivered through the headphones.
Can you share the build that you try? 
Several days ago, we have the volume control problem and fixed it recently.

Comment 4

[Aaron Train [:aaronmt]]

I'm using 12/14 and I still cant control the volume in the FM radio. 

Changing summary as it seems like volume cant be controlled using device rocker either.

--
Unagi (12/14)

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

On 12/16 build:
This happens.
But once I press home button when I am listening to FM, the volume adjusted by rockers immediately comes into effect.

GUESS: Only when visibility is hidden, the fm listens to `audio.volume.content`. Otherwise it's a fixed value(When the FM app is foreground.)

Comment 6

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch1

set the initial value

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 692876 [details] [diff] [review]
patch1

Review of attachment 692876 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you set it in the colon list instead.

Comment 8

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check in patch

set it in the colon list.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69dd94ceaf7e

Please use the checkin-needed keyword in the future instead of setting it on the whiteboard. Also, can you please add a space between your name and your email address in your hg configuration? Thanks!

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/69dd94ceaf7e

Comment 11

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Is this patch sync to b2g-18? 
I don't see this change on this folder.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c2364d6f803
https://hg.mozilla.org/releases/mozilla-b2g18/rev/86771b0b1042

Comment 13

[sthompson]

Verified on Unagi, Build 010320130070201.