_retval is never used and it forces callers to pass *something* in which leads to un-necessary stack allocations.
looking for r/sr.
changes look good to me. r=chak
I presume you've checked the Commercial tree as well. If so, sr=vidur.
whoops. I had checked the ns tree (made the following modification to the single callsite), but forgot to post the patch. Index: nsActivation.cpp =================================================================== RCS file: /m/src/ns/profile/src/nsActivation.cpp,v retrieving revision 1.24 diff -r1.24 nsActivation.cpp 908,910c908,909 < nsXPIDLCString prevEntry; < rv = catman->DeleteCategoryEntry(NS_PROFILE_STARTUP_CATEGORY, NS_ACTIVATION_CONTRACTID, PR_TRUE, < getter_Copies(prevEntry)); --- > rv = catman->DeleteCategoryEntry(NS_PROFILE_STARTUP_CATEGORY, NS_ACTIVATION_CONTRACTID, > PR_TRUE);
vidur has sr'd the above patch.
fix is in.