If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsCategoryManager::DeleteCategoryEntry() has an unused out param

RESOLVED FIXED in mozilla0.9.2

Status

()

Core
XPCOM
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Judson Valeski, Assigned: Judson Valeski)

Tracking

Trunk
mozilla0.9.2
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
_retval is never used and it forces callers to pass *something* in which leads
to un-necessary stack allocations.
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla0.9.2
(Assignee)

Comment 1

17 years ago
Created attachment 36197 [details] [diff] [review]
diffs to activation callsite
(Assignee)

Comment 2

17 years ago
Created attachment 36198 [details] [diff] [review]
mozilla tree-wide diffs.
(Assignee)

Comment 3

17 years ago
looking for r/sr.

Comment 4

17 years ago
changes look good to me. r=chak

Comment 5

17 years ago
I presume you've checked the Commercial tree as well. If so, sr=vidur.
(Assignee)

Comment 6

17 years ago
whoops. I had checked the ns tree (made the following modification to the single
callsite), but forgot to post the patch.

Index: nsActivation.cpp
===================================================================
RCS file: /m/src/ns/profile/src/nsActivation.cpp,v
retrieving revision 1.24
diff -r1.24 nsActivation.cpp
908,910c908,909
<     nsXPIDLCString prevEntry;
<     rv = catman->DeleteCategoryEntry(NS_PROFILE_STARTUP_CATEGORY,
NS_ACTIVATION_CONTRACTID, PR_TRUE,
<                                      getter_Copies(prevEntry));
---
>     rv = catman->DeleteCategoryEntry(NS_PROFILE_STARTUP_CATEGORY,
NS_ACTIVATION_CONTRACTID,
>                                      PR_TRUE);
(Assignee)

Comment 7

17 years ago
vidur has sr'd the above patch.

Updated

17 years ago
Blocks: 83989

Comment 8

17 years ago
a=tor
(Assignee)

Updated

17 years ago
Blocks: 84162
(Assignee)

Comment 9

17 years ago
fix is in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.