820022 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoApp.onBackPressed(GeckoApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

Bug 781143 is not fully fixed.
Indeed, there's one crash in 20.0a1/20121210: bp-9d8a9715-faac-4060-be4a-ddac92121210.

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoApp.onBackPressed(GeckoApp.java:2458)
	at android.app.Activity.onKeyUp(Activity.java:2131)
	at android.view.KeyEvent.dispatch(KeyEvent.java:2655)
	at android.app.Activity.dispatchKeyEvent(Activity.java:2361)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchKeyEvent(PhoneWindow.java:2026)
	at android.view.ViewRootImpl.deliverKeyEventPostIme(ViewRootImpl.java:3577)
	at android.view.ViewRootImpl.deliverKeyEvent(ViewRootImpl.java:3533)
	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:3115)
	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:4155)
	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:4134)
	at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:4226)
	at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:171)
	at android.os.MessageQueue.nativePollOnce(Native Method)
	at android.os.MessageQueue.next(MessageQueue.java:125)
	at android.os.Looper.loop(Looper.java:124)
	at android.app.ActivityThread.main(ActivityThread.java:4965)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:791)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:558)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.GeckoApp.onBackPressed%28GeckoApp.java%29

Comment 1

[:Margaret Leibovic]

I don't have the cycles to work on this right now.

Comment 2

[Scoobidiver (away)]

It's #14 top crasher in 20.0a1.

Comment 3

[Scoobidiver (away)]

It's #9 top crasher in 20.0a2 and #54 in 21.0a1.

Comment 4

[Alex Keybl [:akeybl]]

The crash volume is so low that we're going to leave this on the nom list until after b1 of FF20 is released. Until that time, not worth devoting engineering attention.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Since we released the mobile beta on Monday we're still waiting here for more data collection.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Volume appears stable here, at #15 for Fennec top crashes, not tracking.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hey Aaronmt, do you have a moment to try taking a stab at figuring out where the null pointer check might need to go?

Comment 8

[Aaron Train [:aaronmt]]

Better to go with Wes who reviewed Margaret's patch the first time-around; just about everything in onBackPressed already looks like it has a null-check.

Comment 9

[Wesley Johnston (:wesj)]

Attachment: Patch?

This is the only thing that stood out to me. mLayerView is initialized in initializeChrome as well and might be null? Thant matches with the line number from here:

https://crash-stats.mozilla.com/report/index/c410f016-ad66-414a-b107-6a5f82130328

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/633e6b75af95

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Request uplift please. We want this on Fx22 at a minimum.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/633e6b75af95

Comment 13

[Scoobidiver (away)]

It's #8 top crasher in 20.0.

Comment 14

[bhavana bajaj [:bajaj]]

(In reply to Wesley Johnston (:wesj) from comment #10)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/633e6b75af95

Wes, can you please request nomination for uplift here ?

Comment 15

[Wesley Johnston (:wesj)]

Comment on attachment 730754 [details] [diff] [review]
Patch?

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Forever
User impact if declined: Crashes if you hit back really early in startup
Testing completed (on m-c, etc.): Landed on mc awhile ago. Looks good!
Risk to taking this patch (and alternatives if risky): Very low risk. Just a null check
String or IDL/UUID changes made by this patch: None.

Comment 16

[bhavana bajaj [:bajaj]]

Comment on attachment 730754 [details] [diff] [review]
Patch?

low risk, just a null check and avoids a top-crash. Approving on beta/aurora.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e45b9cf150e1
https://hg.mozilla.org/releases/mozilla-beta/rev/7485b8561100

Comment 18

[Scoobidiver (away)]

There are no crashes in 21.0b2 and above and after 22.0a2/20130408.