Closed Bug 820105 Opened 7 years ago Closed 7 years ago

IonMonkey: callWithABI: support passing the callee in a register

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

We want to use callWithABI to make calls to native functions. However, the baseline compiler will share these "native call" stubs so we can't bake in the actual function pointer.
Just to clarify, you want to make a stub to call  bool (*)(JSContext *, int argc, Value *argv) cases ?  At best you should use a volatile register which is not in the set of argument to hold the pointer of the callee.
Attached patch PatchSplinter Review
This adds a callWithABI overload that takes the callee as Address instead of a function pointer.
Attachment #690840 - Flags: review?(dvander)
Attachment #690840 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/9ff7b0790b02
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.